From: Greg KH <gregkh@linuxfoundation.org>
To: Luis Ortega <luiorpe1@gmail.com>
Cc: pe1dnn@amsat.org, devel@driverdev.osuosl.org,
josh@joshtriplett.org, linux-kernel@vger.kernel.org,
monamagarwal123@gmail.com, paulmck@linux.vnet.ibm.com,
archanakumari959@gmail.com
Subject: Re: [PATCH] staging: wlags49_h2: fix sparse warning "should it be static"
Date: Sat, 24 May 2014 01:53:35 +0900 [thread overview]
Message-ID: <20140523165335.GA6883@kroah.com> (raw)
In-Reply-To: <1399480308-15869-1-git-send-email-luiorpe1@gmail.com>
On Wed, May 07, 2014 at 06:31:48PM +0200, Luis Ortega wrote:
> Fixes the following warning:
> drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not declared. Should it be static?
>
> Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
> ---
> drivers/staging/wlags49_h2/sta_h2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlags49_h2/sta_h2.c b/drivers/staging/wlags49_h2/sta_h2.c
> index 0ba8def..2838faa 100644
> --- a/drivers/staging/wlags49_h2/sta_h2.c
> +++ b/drivers/staging/wlags49_h2/sta_h2.c
> @@ -4468,7 +4468,7 @@ static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
> { 0000, 0000, 0000, 0000, { { 0000, 0000, 0000 } } } /* endsentinel */
> };
>
> -memimage fw_image = {
> +static memimage fw_image = {
> "FUPU7D37dhfwci\001C", /* signature, <format number>, C/Bin type */
> (CFG_PROG_STRCT *) fw_image_code,
> 0x000F368E,
ALWAYS test build your patches. This patch breaks the build :(
greg k-h
prev parent reply other threads:[~2014-05-23 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 16:31 [PATCH] staging: wlags49_h2: fix sparse warning "should it be static" Luis Ortega
2014-05-23 16:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523165335.GA6883@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=archanakumari959@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiorpe1@gmail.com \
--cc=monamagarwal123@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pe1dnn@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.