All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chaitanya Hazarey <c@24.io>
Cc: gregkh@linuxfoundation.org, christoph.kohl@t-online.de,
	michael.hoefler@studium.uni-erlangen.de, rupert@rmuch.net,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings
Date: Sat, 24 May 2014 01:54:24 +0300	[thread overview]
Message-ID: <20140523225424.GT15585@mwanda> (raw)
In-Reply-To: <1400881183-23889-1-git-send-email-c@24.io>

On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:
> 
> drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations
> drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Chaitanya Hazarey <c@24.io>

Still doesn't apply, I'm afraid.

> ---
>  drivers/staging/silicom/bypasslib/bypass.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/silicom/bypasslib/bypass.c b/drivers/staging/silicom/bypasslib/bypass.c
> index a58251f..8e714a8 100644
> --- a/drivers/staging/silicom/bypasslib/bypass.c
> +++ b/drivers/staging/silicom/bypasslib/bypass.c
> @@ -135,6 +135,7 @@ static int doit(int cmd, int if_index, int *data)
>  static int is_dev_sd(int if_index)
>  {
>  	int ret = 0;
> +
>  	SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
>  	return ret >= 0 ? 1 : 0;
>  }
> @@ -186,6 +187,7 @@ static int is_bypass_dev(int if_index)
>  static int is_bypass(int if_index)
>  {
>  	int ret = 0;
> +
>  	SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
>  	if (ret < 0)

There was supposed to be a blank line between the call to
SET_BPLIB_INT_FN() and the return check and it got deleted for some
reason.

regards,
dan carpetner



  parent reply	other threads:[~2014-05-23 22:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 21:39 [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings Chaitanya Hazarey
2014-05-23 22:25 ` Greg KH
2014-05-23 22:54 ` Dan Carpenter [this message]
2014-05-24  5:31   ` Chaitanya Hazarey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140523225424.GT15585@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=c@24.io \
    --cc=christoph.kohl@t-online.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hoefler@studium.uni-erlangen.de \
    --cc=rupert@rmuch.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.