From: Marek Vasut <marex@denx.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux@arm.linux.org.uk, herbert@gondor.apana.org.au,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, Corentin LABBE <clabbe.montjoie@gmail.com>,
linux-crypto@vger.kernel.org, galak@codeaurora.org,
grant.likely@linaro.org, maxime.ripard@free-electrons.com,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator
Date: Sat, 24 May 2014 13:26:26 +0200 [thread overview]
Message-ID: <201405241326.26260.marex@denx.de> (raw)
In-Reply-To: <201405231246.10365.arnd@arndb.de>
On Friday, May 23, 2014 at 12:46:10 PM, Arnd Bergmann wrote:
> On Thursday 22 May 2014, Corentin LABBE wrote:
> > Le 22/05/2014 17:28, Arnd Bergmann a écrit :
> > > On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
> > >> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> > >
> > > My feeling is that this should either be one driver that provides
> > > all five algorithms unconditionally, or five drivers that are each
> > > separate loadable modules and based on top of a common module
> > > that only exports functions but has no active logic itself
> >
> > I agree for the split.
> > It was my first intention but I feared to add too many files.
> > So I propose to split in 6, sunxi-ss-hash.c, sunxi-ss-des.c,
> > sunxi-ss-aes.c, sunxi-ss-rng.c, sunxi-ss-common.c and sunxi-ss.h Does
> > can I add a sunxi-ss directory in drivers/crypto ?
>
> Yes, I think a subdirectory would be best.
Full ACK on this one. Use drivers/crypto/sunxi-ss/ .
[...]
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator
Date: Sat, 24 May 2014 13:26:26 +0200 [thread overview]
Message-ID: <201405241326.26260.marex@denx.de> (raw)
In-Reply-To: <201405231246.10365.arnd@arndb.de>
On Friday, May 23, 2014 at 12:46:10 PM, Arnd Bergmann wrote:
> On Thursday 22 May 2014, Corentin LABBE wrote:
> > Le 22/05/2014 17:28, Arnd Bergmann a ?crit :
> > > On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
> > >> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> > >
> > > My feeling is that this should either be one driver that provides
> > > all five algorithms unconditionally, or five drivers that are each
> > > separate loadable modules and based on top of a common module
> > > that only exports functions but has no active logic itself
> >
> > I agree for the split.
> > It was my first intention but I feared to add too many files.
> > So I propose to split in 6, sunxi-ss-hash.c, sunxi-ss-des.c,
> > sunxi-ss-aes.c, sunxi-ss-rng.c, sunxi-ss-common.c and sunxi-ss.h Does
> > can I add a sunxi-ss directory in drivers/crypto ?
>
> Yes, I think a subdirectory would be best.
Full ACK on this one. Use drivers/crypto/sunxi-ss/ .
[...]
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Corentin LABBE <clabbe.montjoie@gmail.com>,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rdunlap@infradead.org, maxime.ripard@free-electrons.com,
linux@arm.linux.org.uk, herbert@gondor.apana.org.au,
davem@davemloft.net, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator
Date: Sat, 24 May 2014 13:26:26 +0200 [thread overview]
Message-ID: <201405241326.26260.marex@denx.de> (raw)
In-Reply-To: <201405231246.10365.arnd@arndb.de>
On Friday, May 23, 2014 at 12:46:10 PM, Arnd Bergmann wrote:
> On Thursday 22 May 2014, Corentin LABBE wrote:
> > Le 22/05/2014 17:28, Arnd Bergmann a écrit :
> > > On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
> > >> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> > >
> > > My feeling is that this should either be one driver that provides
> > > all five algorithms unconditionally, or five drivers that are each
> > > separate loadable modules and based on top of a common module
> > > that only exports functions but has no active logic itself
> >
> > I agree for the split.
> > It was my first intention but I feared to add too many files.
> > So I propose to split in 6, sunxi-ss-hash.c, sunxi-ss-des.c,
> > sunxi-ss-aes.c, sunxi-ss-rng.c, sunxi-ss-common.c and sunxi-ss.h Does
> > can I add a sunxi-ss directory in drivers/crypto ?
>
> Yes, I think a subdirectory would be best.
Full ACK on this one. Use drivers/crypto/sunxi-ss/ .
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-05-24 11:26 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 15:09 crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2014-05-22 15:09 ` LABBE Corentin
2014-05-22 15:09 ` [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System LABBE Corentin
2014-05-22 15:09 ` LABBE Corentin
2014-05-24 11:21 ` Marek Vasut
2014-05-24 11:21 ` Marek Vasut
2014-05-24 11:21 ` Marek Vasut
2014-05-24 19:20 ` Tomasz Figa
2014-05-24 19:20 ` Tomasz Figa
2014-05-24 19:43 ` Marek Vasut
2014-05-24 19:43 ` Marek Vasut
2014-05-24 19:51 ` Tomasz Figa
2014-05-24 19:51 ` Tomasz Figa
2014-05-24 19:59 ` Marek Vasut
2014-05-24 19:59 ` Marek Vasut
2014-05-25 13:09 ` Maxime Ripard
2014-05-25 13:09 ` Maxime Ripard
2014-05-25 13:07 ` Maxime Ripard
2014-05-25 13:07 ` Maxime Ripard
2014-05-22 15:09 ` [PATCH 2/3] ARM: sun7i: dt: Add Security System to A20 SoC DTS LABBE Corentin
2014-05-22 15:09 ` LABBE Corentin
2014-05-24 11:23 ` Marek Vasut
2014-05-24 11:23 ` Marek Vasut
2014-05-22 15:09 ` [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2014-05-22 15:09 ` LABBE Corentin
2014-05-22 15:28 ` Arnd Bergmann
2014-05-22 15:28 ` Arnd Bergmann
2014-05-22 18:13 ` Corentin LABBE
2014-05-22 18:13 ` Corentin LABBE
2014-05-23 10:46 ` Arnd Bergmann
2014-05-23 10:46 ` Arnd Bergmann
2014-05-24 11:26 ` Marek Vasut [this message]
2014-05-24 11:26 ` Marek Vasut
2014-05-24 11:26 ` Marek Vasut
2014-05-24 12:00 ` Marek Vasut
2014-05-24 12:00 ` Marek Vasut
2014-05-25 11:58 ` Corentin LABBE
2014-05-25 11:58 ` Corentin LABBE
2014-05-25 14:30 ` Marek Vasut
2014-05-25 14:30 ` Marek Vasut
2014-07-23 13:57 ` Herbert Xu
2014-07-23 13:57 ` Herbert Xu
2014-07-23 14:07 ` Marek Vasut
2014-07-23 14:07 ` Marek Vasut
2014-07-23 14:13 ` Herbert Xu
2014-07-23 14:13 ` Herbert Xu
2014-07-23 15:51 ` Marek Vasut
2014-07-23 15:51 ` Marek Vasut
[not found] ` <201407231751.02050.marex-ynQEQJNshbs@public.gmane.org>
2014-07-23 18:52 ` Corentin LABBE
2014-07-23 18:52 ` Corentin LABBE
2014-07-23 18:52 ` Corentin LABBE
2014-07-23 19:38 ` Marek Vasut
2014-07-23 19:38 ` Marek Vasut
2014-07-24 1:40 ` Herbert Xu
2014-07-24 1:40 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201405241326.26260.marex@denx.de \
--to=marex@denx.de \
--cc=arnd@arndb.de \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.