All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chaitanya Hazarey <c@24.io>
Cc: chad@dahc.us, michael.banken@mathe.stud.uni-erlangen.de,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Fixed a lot of checkpatch.pl warnings
Date: Sun, 25 May 2014 11:03:57 -0700	[thread overview]
Message-ID: <20140525180357.GA18332@kroah.com> (raw)
In-Reply-To: <1400909128-1409-1-git-send-email-c@24.io>

On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix the
> following warning issued by checkpatch.pl:
> 
> WARNING: Missing a blank line after declarations
> 
> Thanks Greg K-H and Dan for the patience. Hope it works this time, I did
> apply it against staging and it was ok. 


Hm, something is odd, it still doesn't apply properly:

$ p1 < ../s1
checking file drivers/staging/silicom/bpctl_mod.c
Hunk #40 FAILED at 4773.
Hunk #41 FAILED at 4821.
...
Hunk #89 FAILED at 7534.
3 out of 89 hunks FAILED

Can you refresh this against my tree again and resend?  I think we are
out of sync here still.

thanks,

greg k-h

  parent reply	other threads:[~2014-05-25 18:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-24  5:25 [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Fixed a lot of checkpatch.pl warnings Chaitanya Hazarey
2014-05-24  7:22 ` Dan Carpenter
2014-05-25 18:03 ` Greg KH [this message]
2014-05-25 18:29   ` Chaitanya Hazarey
  -- strict thread matches above, loose matches on Subject: below --
2014-05-25 18:59 Chaitanya Hazarey
2014-05-25 22:13 ` Greg KH
2014-05-25 22:30 ` Dan Carpenter
2014-05-26  0:09   ` Chaitanya Hazarey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140525180357.GA18332@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=c@24.io \
    --cc=chad@dahc.us \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.banken@mathe.stud.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.