From: Dan Carpenter <dan.carpenter@oracle.com>
To: Heesub Shin <heesub.shin@samsung.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
"Sunghwan Yun" <sunghwan.yun@samsung.com>,
"Daeseok Youn" <daeseok.youn@gmail.com>,
linux-kernel@vger.kernel.org, "Arve Hjønnevåg" <arve@android.com>,
"John Stultz" <john.stultz@linaro.org>,
"Colin Cross" <ccross@android.com>,
"Rebecca Schultz Zavin" <rebecca@android.com>,
"Mitchel Humpherys" <mitchelh@codeaurora.org>
Subject: Re: [PATCH 1/9] staging: ion: tidy up a bit
Date: Mon, 26 May 2014 13:36:12 +0300 [thread overview]
Message-ID: <20140526103612.GE15585@mwanda> (raw)
In-Reply-To: <1401098701-24049-1-git-send-email-heesub.shin@samsung.com>
On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
> @@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct ion_system_heap *heap,
>
> info->page = page;
> info->order = orders[i];
> - INIT_LIST_HEAD(&info->list);
> return info;
> }
> kfree(info);
Wait. How does this code work without that INIT_LIST_HEAD()? What am
I missing here...
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-26 10:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 10:04 [PATCH 1/9] staging: ion: tidy up a bit Heesub Shin
2014-05-26 10:04 ` [PATCH 2/9] staging: ion: simplify ion_page_pool_total() Heesub Shin
2014-05-26 10:04 ` [PATCH 3/9] staging: ion: use compound pages on high order pages for system heap Heesub Shin
2014-05-26 10:04 ` [PATCH 4/9] staging: ion: remove struct ion_page_pool_item Heesub Shin
2014-05-27 0:39 ` Heesub Shin
2014-05-26 10:04 ` [PATCH 5/9] staging: ion: remove order from struct page_info Heesub Shin
2014-05-26 10:04 ` [PATCH 6/9] staging: ion: remove " Heesub Shin
2014-05-27 18:36 ` Mitchel Humpherys
2014-05-27 21:16 ` Dan Carpenter
2014-05-26 10:04 ` [PATCH 7/9] staging: ion: remove order argument from free_buffer_page() Heesub Shin
2014-05-27 18:37 ` Mitchel Humpherys
2014-05-26 10:05 ` [PATCH 8/9] staging: ion: shrink highmem pages on kswapd Heesub Shin
2014-05-26 10:05 ` [PATCH 9/9] staging: ion: optimize struct ion_system_heap Heesub Shin
2014-05-26 10:36 ` Dan Carpenter [this message]
2014-05-27 0:58 ` [PATCH 1/9] staging: ion: tidy up a bit Heesub Shin
2014-05-27 9:55 ` Dan Carpenter
2014-05-27 18:52 ` Greg Kroah-Hartman
2014-05-27 18:59 ` John Stultz
2014-05-28 6:52 ` [PATCH v2 0/9] staging: ion: system heap and page pool fixes Heesub Shin
2014-05-28 6:52 ` [PATCH v2 1/9] staging: ion: tidy up a bit Heesub Shin
2014-05-29 20:42 ` Greg Kroah-Hartman
2014-05-30 1:22 ` Heesub Shin
2014-05-30 1:26 ` [PATCH v2 RESEND 1/4] staging: ion: remove order from struct page_info Heesub Shin
2014-05-30 1:26 ` [PATCH v2 RESEND 2/4] staging: ion: remove " Heesub Shin
2014-05-30 1:26 ` [PATCH v2 RESEND 3/4] staging: ion: remove order argument from free_buffer_page() Heesub Shin
2014-05-30 1:26 ` [PATCH v2 RESEND 4/4] staging: ion: optimize struct ion_system_heap Heesub Shin
2014-05-28 6:52 ` [PATCH v2 2/9] staging: ion: simplify ion_page_pool_total() Heesub Shin
2014-05-28 6:52 ` [PATCH v2 3/9] staging: ion: remove struct ion_page_pool_item Heesub Shin
2014-05-28 6:52 ` [PATCH v2 4/9] staging: ion: use compound pages on high order pages for system heap Heesub Shin
2014-05-28 6:52 ` [PATCH v2 5/9] staging: ion: remove order from struct page_info Heesub Shin
2014-05-28 6:52 ` [PATCH v2 6/9] staging: ion: remove " Heesub Shin
2014-05-28 6:52 ` [PATCH v2 7/9] staging: ion: remove order argument from free_buffer_page() Heesub Shin
2014-05-28 6:52 ` [PATCH v2 8/9] staging: ion: shrink highmem pages on kswapd Heesub Shin
2014-05-28 6:53 ` [PATCH v2 9/9] staging: ion: optimize struct ion_system_heap Heesub Shin
2014-05-28 16:28 ` [PATCH v2 0/9] staging: ion: system heap and page pool fixes Mitchel Humpherys
2014-05-28 20:01 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526103612.GE15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=heesub.shin@samsung.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitchelh@codeaurora.org \
--cc=rebecca@android.com \
--cc=sunghwan.yun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.