From: Shawn Guo <shawn.guo@freescale.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org, lars@metafoo.de
Subject: Re: [PATCH v5] ASoC: sgtl5000: Fix the cache handling
Date: Tue, 27 May 2014 15:34:58 +0800 [thread overview]
Message-ID: <20140527073452.GA8860@dragon> (raw)
In-Reply-To: <1401111260-23320-1-git-send-email-fabio.estevam@freescale.com>
On Mon, May 26, 2014 at 10:34:20AM -0300, Fabio Estevam wrote:
> Since commit e5d80e82e32e (ASoC: sgtl5000: Convert to use regmap directly) a
> kernel oops is observed after a suspend/resume sequence.
>
> The kernel oops happens inside sgtl5000_restore_regs() as codec->reg_cache is no
> longer a valid pointer.
>
> Add the remaining register entries into sgtl5000_reg_defaults[] and remove
> sgtl5000_restore_regs() completely, which allows suspend/resume to work fine and
> make the code simpler.
>
> Tested on a im53-qsb board.
>
> Reported-by: Shawn Guo <shawn.guo@freescale.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Tested-by: Shawn Guo <shawn.guo@freescale.com>
next prev parent reply other threads:[~2014-05-27 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 13:34 [PATCH v5] ASoC: sgtl5000: Fix the cache handling Fabio Estevam
2014-05-27 7:34 ` Shawn Guo [this message]
2014-05-27 11:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527073452.GA8860@dragon \
--to=shawn.guo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=lars@metafoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.