From: Ralf Baechle <ralf@linux-mips.org>
To: Andreas Herrmann <herrmann.der.user@googlemail.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB
Date: Tue, 27 May 2014 11:05:27 +0200 [thread overview]
Message-ID: <20140527090527.GG20055@linux-mips.org> (raw)
In-Reply-To: <20140523213701.GD23153@alberich>
On Fri, May 23, 2014 at 11:37:01PM +0200, Andreas Herrmann wrote:
> > void __init smp_cpus_done(unsigned int max_cpus)
> > {
> > - mp_ops->cpus_done();
> > + if (cpus_done)
> > + mp_ops->cpus_done();
> > }
> >
> > which would make a NULL cpus_done function pointer safe and allow empty definitions
> > to be removed.
>
> I'd prefer this solution over complete removal of the hook.
In the end that's what I just did.
Which leaves smp_cpus_done() empty. I think I'm going to put in a
function to print a summary of CPUs booted but that's for another
patch.
Ralf
prev parent reply other threads:[~2014-05-27 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 16:16 [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB Paul Bolle
2014-05-21 20:27 ` Andreas Herrmann
2014-05-21 20:44 ` Paul Bolle
2014-05-22 13:26 ` Ralf Baechle
2014-05-23 21:37 ` Andreas Herrmann
2014-05-27 9:05 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527090527.GG20055@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=herrmann.der.user@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.