Re: Please patch key_mod.c

[Tyler Hicks <tyhicks@canonical.com>]

[-- Attachment #1: Type: text/plain, Size: 1933 bytes --]

Sorry for missing this patch, I've been traveling.

On 2014-05-10 19:33:17, Jaroslav Fojtik wrote:
> Dears,
> 
> Please patch key_mod.c.

This change looks good to me. I've pushed it to lp:ecryptfs. Thanks!

Tyler

> 
> If you receive following message, it is totally frustrating because you do not know which
> directory attempted to open. The path at least gives some info about it.
> 
> ======================================================================================
> 
> mount.ecryptfs /DATA/.BACKUP /DATA/BACKUP -o 
> key=passphrase,ecryptfs_cipher=aes,ecryptfs_key_bytes=16,ecryptfs_passthrough=no,ecryptfs_
> enable_filename_crypto=yes,ecryptfs_fnek_sig=87f8f52c6f46cfca
> Error attempting to evaluate mount options: [-1] Operation not permitted
> Check your system logs for details on why this happened.
> Try updating your ecryptfs-utils package, and/or
> submit a bug report on https://bugs.launchpad.net/ecryptfs
> 
> 2 keys in keyring:
> 620524981: --alswrv     0     0 user: 87f8f52C6f46cfcA
> 1017206571: --alswrv     0     0 user: 87f8f52c6f46cfca
> 
> Mar 30 18:40:39 ESC_router mount.ecryptfs: ERROR: Could not open key_mod directory 
> Mar 30 18:40:39 ESC_router mount.ecryptfs: Error attempting to get key module list; rc = 
> [-1] 
> 
> 
> best regards
>    Jara
> 
> ---------------------------------------------------
> 
> *** key_mod.c.old	Sat May 10 17:57:51 2014
> --- key_mod.c	Sat May 10 17:58:31 2014
> ***************
> *** 252,258 ****
>   	}
>   	if (!(dp = opendir(dir_name))) {
>   		syslog(LOG_WARNING,
> ! 		       "ERROR: Could not open key_mod directory\n");
>   		rc = -EPERM;
>   		goto out;
>   	}
> --- 252,258 ----
>   	}
>   	if (!(dp = opendir(dir_name))) {
>   		syslog(LOG_WARNING,
> ! 		       "ERROR: Could not open key_mod directory [%s]\n", dir_name);
>   		rc = -EPERM;
>   		goto out;
>   	}
> 
> 
> 
> 
> 



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]