From: Stephen Hemminger <stephen@networkplumber.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/4] get_maintainer: shut up perl critic
Date: Tue, 27 May 2014 10:00:49 -0700 [thread overview]
Message-ID: <20140527100049.52f41546@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1401154356.519.45.camel@joe-AO725>
On Mon, 26 May 2014 18:32:36 -0700
Joe Perches <joe@perches.com> wrote:
> On Mon, 2014-05-26 at 18:22 -0700, Stephen Hemminger wrote:
> > Use the no critic annotation, with comment, to silence perl critic
> > for places where the code is correct as is.
>
> I think this uglifies the code and a more sensible solution
> is not using perlcritic
>
>
Perlcritic like checkpatch or sparse is a useful tool but often generates
false positives. Doing this allows shutting up the tool.
next prev parent reply other threads:[~2014-05-27 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 20:33 [PATCH 0/4] get_maintainer script cleanups Stephen Hemminger
2014-05-26 20:33 ` [PATCH 1/4] get_maintainer: use three argument open Stephen Hemminger
2014-05-26 20:33 ` [PATCH 2/4] get_maintainer: remove quoting on hash label Stephen Hemminger
2014-05-26 20:33 ` [PATCH 3/4] get_maintainer: use array for defining available version control Stephen Hemminger
2014-05-26 20:33 ` [PATCH 4/4] get_maintainer: use anonymous function instead of eval Stephen Hemminger
2014-05-27 1:00 ` [PATCH 0/4] get_maintainer script cleanups Joe Perches
2014-05-27 1:03 ` Joe Perches
2014-05-27 1:09 ` Stephen Hemminger
2014-05-27 1:22 ` [PATCH 5/4] get_maintainer: shut up perl critic Stephen Hemminger
2014-05-27 1:32 ` Joe Perches
2014-05-27 17:00 ` Stephen Hemminger [this message]
2014-05-27 1:06 ` [PATCH 0/4] get_maintainer script cleanups Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527100049.52f41546@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.