All of lore.kernel.org
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: mvebu: Staticize local variables
Date: Tue, 27 May 2014 13:51:08 +0200	[thread overview]
Message-ID: <20140527135108.1642833b@free-electrons.com> (raw)
In-Reply-To: <1401190629-24559-1-git-send-email-sachin.kamat@linaro.org>

Dear Sachin Kamat,

On Tue, 27 May 2014 17:07:09 +0530, Sachin Kamat wrote:
> Symbols local to this file are made static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/mach-mvebu/pmsu.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c
> index 53a55c8520bf..950105871480 100644
> --- a/arch/arm/mach-mvebu/pmsu.c
> +++ b/arch/arm/mach-mvebu/pmsu.c
> @@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
>  }
>  
>  /* No locking is needed because we only access per-CPU registers */
> -void armada_370_xp_pmsu_idle_prepare(bool deepidle)
> +static void armada_370_xp_pmsu_idle_prepare(bool deepidle)

I already submitted a patch for this one yesterday:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/259849.html.

>  {
>  	unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
>  	u32 reg;
> @@ -263,7 +263,7 @@ static struct notifier_block
> armada_370_xp_cpu_pm_notifier = { .notifier_call =
> armada_370_xp_cpu_pm_notify, };
>  
> -int __init armada_370_xp_cpu_pm_init(void)
> +static int __init armada_370_xp_cpu_pm_init(void)

Indeed, this one needs to be fixed.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-05-27 11:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 11:37 [PATCH 1/1] ARM: mvebu: Staticize local variables Sachin Kamat
2014-05-27 11:51 ` Thomas Petazzoni [this message]
2014-05-27 11:54   ` Sachin Kamat
2014-05-27 12:01     ` Thomas Petazzoni
2014-05-27 12:03       ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140527135108.1642833b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.