From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] misc: fix create_inode warnings with LLVM
Date: Tue, 27 May 2014 12:51:21 -0400 [thread overview]
Message-ID: <20140527165121.GD1158@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1405271834430.2055@localhost.localdomain>
On Tue, May 27, 2014 at 06:34:52PM +0200, Lukáš Czerner wrote:
> On Tue, 20 May 2014, Andreas Dilger wrote:
>
> > Date: Tue, 20 May 2014 17:12:22 -0600
> > From: Andreas Dilger <adilger@dilger.ca>
> > To: tytso@mit.edu
> > Cc: linux-ext4@vger.kernel.org, Andreas Dilger <adilger@dilger.ca>
> > Subject: [PATCH] misc: fix create_inode warnings with LLVM
> >
> > Fix name clash in do_mknod_internal() due to local variables named
> > "major" and "minor" shadowing identical macro names.
> >
> > Also, no need to set the major and minor device for a FIFO inode.
> >
> > Signed-off-by: Andreas Dilger <adilger@dilger.ca>
>
> Looks good, thanks!
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Applied, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-05-27 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 23:12 [PATCH] misc: fix create_inode warnings with LLVM Andreas Dilger
2014-05-27 16:34 ` Lukáš Czerner
2014-05-27 16:51 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527165121.GD1158@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.