From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@amacapital.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Andi Kleen <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] x86, MCE: Flesh out when to panic comment
Date: Wed, 28 May 2014 00:24:04 +0200 [thread overview]
Message-ID: <20140527222404.GE4366@pd.tnic> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F3281EEA5@ORSMSX114.amr.corp.intel.com>
On Tue, May 27, 2014 at 09:53:56PM +0000, Luck, Tony wrote:
> It is far from obvious that mce_severity() will always say that an
> error detected inside the kernel will be fatal.
Oh yeah, it needs a good cleansing rewrite, that's for sure.
And this tolerant check looks fishy to me:
if (s->sev >= MCE_UC_SEVERITY && ctx == IN_KERNEL) {
if (panic_on_oops || tolerant < 1)
return MCE_PANIC_SEVERITY;
}
since we set it to 1 by default. But I'll look again on a clear head
tomorrow - it is too late here.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-05-27 22:24 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 0:53 [RFC] x86_64: A real proposal for iret-less return to kernel Andy Lutomirski
2014-05-21 2:27 ` Steven Rostedt
2014-05-21 2:33 ` H. Peter Anvin
2014-05-21 2:39 ` Andy Lutomirski
2014-05-21 9:46 ` Borislav Petkov
2014-05-21 15:21 ` Andy Lutomirski
2014-05-21 16:30 ` Borislav Petkov
2014-05-21 17:52 ` Andy Lutomirski
2014-05-21 18:07 ` Borislav Petkov
2014-05-21 12:51 ` Jiri Kosina
2014-05-21 15:21 ` Andy Lutomirski
2014-05-21 16:33 ` Borislav Petkov
2014-05-21 21:25 ` Jiri Kosina
2014-05-21 21:35 ` Andy Lutomirski
2014-05-21 21:48 ` Borislav Petkov
2014-05-21 21:52 ` Andy Lutomirski
2014-05-21 21:55 ` Borislav Petkov
2014-05-21 21:59 ` Jiri Kosina
2014-05-21 21:59 ` Andy Lutomirski
2014-05-21 22:01 ` Luck, Tony
2014-05-21 22:13 ` Andy Lutomirski
2014-05-21 22:17 ` Borislav Petkov
2014-05-21 22:20 ` Andy Lutomirski
2014-05-21 22:36 ` Borislav Petkov
2014-05-21 22:18 ` Luck, Tony
2014-05-21 22:24 ` Andy Lutomirski
2014-05-21 22:32 ` Luck, Tony
2014-05-21 22:39 ` Andy Lutomirski
2014-05-21 22:48 ` Borislav Petkov
2014-05-21 22:52 ` Andy Lutomirski
2014-05-21 23:02 ` Borislav Petkov
2014-05-21 23:05 ` Luck, Tony
2014-05-21 23:07 ` Andy Lutomirski
2014-05-21 23:19 ` Luck, Tony
2014-05-21 23:30 ` Linus Torvalds
2014-05-21 23:40 ` Luck, Tony
2014-05-21 23:51 ` Borislav Petkov
2014-05-22 0:03 ` Linus Torvalds
2014-05-22 8:50 ` Borislav Petkov
2014-05-22 0:05 ` Andy Lutomirski
2014-05-21 21:37 ` Linus Torvalds
2014-05-21 21:43 ` Borislav Petkov
2014-05-21 21:45 ` H. Peter Anvin
2014-05-21 21:47 ` Andy Lutomirski
2014-05-21 21:54 ` Borislav Petkov
2014-05-21 22:00 ` H. Peter Anvin
2014-05-21 22:11 ` Borislav Petkov
2014-05-21 22:13 ` H. Peter Anvin
2014-05-21 22:21 ` Borislav Petkov
2014-05-26 10:18 ` [PATCH] x86, MCE: Flesh out when to panic comment Borislav Petkov
2014-05-26 10:51 ` Jiri Kosina
2014-05-26 11:06 ` Borislav Petkov
2014-05-26 16:47 ` Andy Lutomirski
2014-05-26 17:51 ` Borislav Petkov
2014-05-26 17:59 ` Andy Lutomirski
2014-05-27 21:53 ` Luck, Tony
2014-05-27 22:24 ` Borislav Petkov [this message]
2014-05-27 22:33 ` Luck, Tony
2014-05-21 21:50 ` [RFC] x86_64: A real proposal for iret-less return to kernel Jiri Kosina
2014-05-21 18:11 ` Andy Lutomirski
2014-05-21 22:36 ` H. Peter Anvin
2014-05-21 22:41 ` Andy Lutomirski
2014-05-21 23:03 ` H. Peter Anvin
2014-05-21 22:25 ` Andi Kleen
2014-05-21 22:32 ` Andy Lutomirski
2014-05-21 22:33 ` Linus Torvalds
2014-05-21 23:23 ` Andi Kleen
2014-05-21 23:34 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527222404.GE4366@pd.tnic \
--to=bp@alien8.de \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.