From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/2, RFC] xfsprogs: check fs sector size in platform_findsizes()
Date: Tue, 27 May 2014 22:39:12 -0700 [thread overview]
Message-ID: <20140528053912.GA13166@infradead.org> (raw)
In-Reply-To: <53852A61.90400@sandeen.net>
On Tue, May 27, 2014 at 07:14:25PM -0500, Eric Sandeen wrote:
> Try the xfs geometry ioctl if the mkfs target resides
> in a file; this gives us the equivalent of a device
> sector size.
>
> This does, however, emit a warning if the target file
> exists on a non-XFS filesystem, and that might not be super.
You could simple not print the warning in case this bothers you..
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-28 5:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 0:12 [PATCH 0/2, RFC] xfsprogs: try to handle mkfs of a file on 4k sector device Eric Sandeen
2014-05-28 0:14 ` [PATCH 1/2, RFC] xfsprogs: check fs sector size in platform_findsizes() Eric Sandeen
2014-05-28 5:39 ` Christoph Hellwig [this message]
2014-05-28 0:15 ` [PATCH 2/2, RFC] mkfs.xfs: don't call blkid_get_topology on regular files Eric Sandeen
2014-05-28 5:40 ` Christoph Hellwig
2014-05-28 12:31 ` Eric Sandeen
2014-05-28 5:41 ` [PATCH 0/2, RFC] xfsprogs: try to handle mkfs of a file on 4k sector device Christoph Hellwig
2014-05-28 13:50 ` Eric Sandeen
2014-06-05 19:13 ` [PATCH 1/2 V2] " Eric Sandeen
2014-06-06 15:20 ` Brian Foster
2014-06-05 19:15 ` [PATCH 2/2 V2] mkfs.xfs: don't call blkid_get_topology on regular files Eric Sandeen
2014-06-06 15:21 ` Brian Foster
2014-06-06 15:27 ` Eric Sandeen
2014-06-06 16:47 ` Eric Sandeen
2014-06-06 19:21 ` [PATCH 2/2 V3] mkfs.xfs: don't call blkid_get_topology on existing " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528053912.GA13166@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.