From: Will Deacon <will.deacon@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH] kvmtool: virtio: pass trapped vcpu to IO accessors
Date: Wed, 28 May 2014 14:51:46 +0100 [thread overview]
Message-ID: <20140528135145.GH15222@arm.com> (raw)
In-Reply-To: <1401186259-3331-1-git-send-email-marc.zyngier@arm.com>
On Tue, May 27, 2014 at 11:24:19AM +0100, Marc Zyngier wrote:
> The recent introduction of bi-endianness on arm/arm64 had the
> odd effect of breaking virtio-pci support on these platforms, as the
> device endian field defaults to being VIRTIO_ENDIAN_HOST, which
> is the wrong thing to have on a bi-endian capable architecture.
>
> The fix is to check for the endianness on the ioport path the
> same way we do it for mmio, which implies passing the vcpu all
> the way down. Patch is a bit ugly, but aligns MMIO and ioport nicely.
>
> Tested on arm64 and x86.
>
> Acked-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Please can you pick this one up Pekka? It fixes an unfortunate regression
in PCI caused by the bi-endianness series.
Cheers,
Will
prev parent reply other threads:[~2014-05-28 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 10:24 [PATCH] kvmtool: virtio: pass trapped vcpu to IO accessors Marc Zyngier
2014-05-28 13:51 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528135145.GH15222@arm.com \
--to=will.deacon@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.