All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH V2 3/3] lib/debugobjects.c: convert printk(KERN_DEBUG to pr_debug
Date: Thu, 29 May 2014 08:51:47 -0700	[thread overview]
Message-ID: <20140529155147.GC31286@thin> (raw)
In-Reply-To: <20140529092532.850a410f6df7b3ae57726a41@skynet.be>

On Thu, May 29, 2014 at 09:25:32AM +0200, Fabian Frederick wrote:
> Direct conversion of one KERN_DEBUG message without DEBUG definition
> (suggested by Josh Triplett)
> 
> That message will now be disabled by default.
> (see Documentation/CodingStyle Chapter 13)
> 
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  lib/debugobjects.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
> index b628247..547f7f9 100644
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -1061,8 +1061,8 @@ static int __init debug_objects_replace_static_objects(void)
>  	}
>  	local_irq_enable();
>  
> -	printk(KERN_DEBUG "ODEBUG: %d of %d active objects replaced\n", cnt,
> -	       obj_pool_used);
> +	pr_debug("%d of %d active objects replaced\n",
> +		 cnt, obj_pool_used);
>  	return 0;
>  free:
>  	hlist_for_each_entry_safe(obj, tmp, &objects, node) {
> -- 
> 1.9.1

      reply	other threads:[~2014-05-29 15:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29  7:25 [PATCH V2 3/3] lib/debugobjects.c: convert printk(KERN_DEBUG to pr_debug Fabian Frederick
2014-05-29 15:51 ` Josh Triplett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140529155147.GC31286@thin \
    --to=josh@joshtriplett.org \
    --cc=akpm@linux-foundation.org \
    --cc=fabf@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.