From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] Revert "staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()"
Date: Thu, 29 May 2014 09:11:01 -0700 [thread overview]
Message-ID: <20140529161101.GA802@kroah.com> (raw)
In-Reply-To: <20140529070127.GA1347@devel.8.8.4.4>
On Thu, May 29, 2014 at 04:01:27PM +0900, Daeseok Youn wrote:
> This reverts commit 0ade4a34fd439d62df46937e8f3e584eb0879579.
>
> This patch removes kfree for serial_ports in dgap_tty_register_ports()
> if the "brd->printer_ports" allocation fails and serial_ports may be
> freed by calling dgap_tty_uninit() within other patch.
> That patch has an error handling but incomplete cleanup
> so it need to call kfree() for brd->serial_ports in
> dgap_tty_register_ports().
>
> Conflicts:
>
> drivers/staging/dgap/dgap.c
> ---
> drivers/staging/dgap/dgap.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
-ENOSIGNEDOFFBY :(
prev parent reply other threads:[~2014-05-29 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 7:01 [PATCH] Revert "staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()" Daeseok Youn
2014-05-29 16:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529161101.GA802@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.