From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables 4/4] netfilter: nf_tables: atomic allocation in set notifications from rcu callback
Date: Thu, 29 May 2014 18:41:39 +0100 [thread overview]
Message-ID: <20140529174138.GA22072@macbook.localnet> (raw)
In-Reply-To: <1401356907-6840-5-git-send-email-pablo@netfilter.org>
On Thu, May 29, 2014 at 11:48:27AM +0200, Pablo Neira Ayuso wrote:
> Use GFP_ATOMIC allocations when sending removal notifications of
> anonymous sets from rcu callback context. Sleeping in that context
> is illegal.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> net/netfilter/nf_tables_api.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
> index dbf8236..043f9a3 100644
> --- a/net/netfilter/nf_tables_api.c
> +++ b/net/netfilter/nf_tables_api.c
> @@ -2191,7 +2191,7 @@ nla_put_failure:
>
> static int nf_tables_set_notify(const struct nft_ctx *ctx,
> const struct nft_set *set,
> - int event)
> + int event, int gfp_flags)
Minor improvement: the proper type is gfp_t.
prev parent reply other threads:[~2014-05-29 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 9:48 [PATCH nftables 0/4] more transaction updates Pablo Neira Ayuso
2014-05-29 9:48 ` [PATCH nftables 1/4] netfilter: nf_tables: release objects in reverse order in the abort path Pablo Neira Ayuso
2014-05-29 9:48 ` [PATCH nftables 2/4] netfilter: nf_rbtree: introduce locking Pablo Neira Ayuso
2014-05-29 9:48 ` [PATCH nftables 3/4] netfilter: nf_tables: allow to delete several objects from a batch Pablo Neira Ayuso
2014-05-29 9:48 ` [PATCH nftables 4/4] netfilter: nf_tables: atomic allocation in set notifications from rcu callback Pablo Neira Ayuso
2014-05-29 17:41 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529174138.GA22072@macbook.localnet \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.