All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: navin patidar <navin.patidar@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/18] staging: rtl8188eu: Remove "silentreset_mutex" from struct sreset_priv
Date: Fri, 30 May 2014 00:48:52 +0300	[thread overview]
Message-ID: <20140529214852.GD15585@mwanda> (raw)
In-Reply-To: <1401385858-28722-1-git-send-email-navin.patidar@gmail.com>

I have reviewed this patchset.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

Btw, I wish you would fold some of these patches together next time.
For example, patches 3-6 are very closely related and they should have
just been one thing.

Or the times where the change log says, "I am going to delete function
frob_frob_frob_whatever() in the next patch."  Just delete it in that
patch.

But anyway, you're doing a great job.  Very nice clean ups.

regards,
dan carpenter


      parent reply	other threads:[~2014-05-29 21:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 17:50 [PATCH 01/18] staging: rtl8188eu: Remove "silentreset_mutex" from struct sreset_priv navin patidar
2014-05-29 17:50 ` [PATCH 02/18] staging: rtl8188eu:Remove "silent_reset_inprogress" " navin patidar
2014-05-29 17:50 ` [PATCH 03/18] staging: rtl8188eu: Use rtw_hal_sreset_init() in rtw_reset_drv_sw() navin patidar
2014-05-29 17:50 ` [PATCH 04/18] staging: rtl8188eu: Remove unused function rtw_hal_sreset_reset_value() navin patidar
2014-05-29 17:50 ` [PATCH 05/18] staging: rtl8188eu: Remove unused function pointer ->sreset_reset_value navin patidar
2014-05-29 17:50 ` [PATCH 06/18] staging: rtl8188eu: Remove unused function reset_reset_value() navin patidar
2014-05-29 17:50 ` [PATCH 07/18] staging: rtl8188eu: Remove function rtw_hal_sreset_xmit_status_check() navin patidar
2014-05-29 17:50 ` [PATCH 08/18] staging: rtl8188eu: Remove unused function rtl8188e_sreset_xmit_status_check() navin patidar
2014-05-29 17:50 ` [PATCH 09/18] staging:rtl8188eu: Remove function rtw_hal_sreset_linked_status_check() navin patidar
2014-05-29 17:50 ` [PATCH 10/18] staging:rtl8188eu: Remove function rtl8188e_sreset_linked_status_check() navin patidar
2014-05-29 17:50 ` [PATCH 11/18] staging: rtl8188eu: Remove function rtw_hal_sreset_reset() navin patidar
2014-05-29 17:50 ` [PATCH 12/18] staging: rtl8188eu: Remove function rtl8188e_silentreset_for_specific_platform() navin patidar
2014-05-29 17:50 ` [PATCH 13/18] staging: rtl8188eu: Remove empty files rtl8188e_sreset.[c|h] navin patidar
2014-05-29 17:50 ` [PATCH 14/18] staging: rtl8188eu: Remove "last_tx_time" from struct sreset_priv navin patidar
2014-05-29 17:50 ` [PATCH 15/18] staging: rtl8188eu: Remove "last_tx_complete_time" " navin patidar
2014-05-29 17:50 ` [PATCH 16/18] staging: rtl8188eu: Remove Hal8188EReg.h file navin patidar
2014-05-29 17:50 ` [PATCH 17/18] staging: rtl8188eu: Remove unused function declaration navin patidar
2014-05-29 17:50 ` [PATCH 18/18] staging: rtl8188eu: Remove usb_vendor_req.h header file navin patidar
2014-05-29 21:48 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140529214852.GD15585@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navin.patidar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.