From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] remove duplicate checking code Date: Fri, 30 May 2014 20:21:43 +0200 Message-ID: <20140530182143.GK17056@8bytes.org> References: <1400225980-12797-1-git-send-email-vaughan.cao@oracle.com> <20140526093959.GH17056@8bytes.org> <1401371147.22923.4.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1401371147.22923.4.camel@x220> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Bolle Cc: Vaughan Cao , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org T24gVGh1LCBNYXkgMjksIDIwMTQgYXQgMDM6NDU6NDdQTSArMDIwMCwgUGF1bCBCb2xsZSB3cm90 ZToKPiBPbiBNb24sIDIwMTQtMDUtMjYgYXQgMTE6MzkgKzAyMDAsIEpvZXJnIFJvZWRlbCB3cm90 ZToKPiA+IE9uIEZyaSwgTWF5IDE2LCAyMDE0IGF0IDAzOjM5OjQwUE0gKzA4MDAsIFZhdWdoYW4g Q2FvIHdyb3RlOgo+ID4gPiBhbWRfaW9tbXVfcmxvb2t1cF90YWJsZVtkZXZpZF0gIT0gTlVMTCBp cyBhbHJlYWR5IGd1YXJhbnRlZWQgYnkgY2hlY2tfZGV2aWNlCj4gPiA+IGNhbGxlZCBiZWZvcmUs IGl0J3MgZmluZSB0byBhdHRhY2ggZGV2aWNlIGF0IHRoaXMgcG9pbnQuCj4gPiA+IAo+ID4gPiBT aWduZWQtb2ZmLWJ5OiBWYXVnaGFuIENhbyA8dmF1Z2hhbi5jYW9Ab3JhY2xlLmNvbT4KPiA+ID4g LS0tCj4gPiA+ICBkcml2ZXJzL2lvbW11L2FtZF9pb21tdS5jIHwgNiAtLS0tLS0KPiA+ID4gIDEg ZmlsZSBjaGFuZ2VkLCA2IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBBcHBsaWVkLCB0aGFua3MuCj4g Cj4gVGhpcyBvbmUgZW50ZXJlZCBsaW51eC1uZXh0LCBhcyBvZiBuZXh0LTIwMTQyNTI3LCBpbiBj b21taXQgZWNlZjExNWQ0NTQwCj4gKCJpb21tdS9hbWQ6IFJlbW92ZSBkdXBsaWNhdGUgY2hlY2tp bmcgY29kZSIpLiBJdCB0cmlnZ2VycyBhbiBvYnZpb3VzbHkKPiBjb3JyZWN0IHdhcm5pbmc6Cj4g ICAgIGRyaXZlcnMvaW9tbXUvYW1kX2lvbW11LmM6IEluIGZ1bmN0aW9uIOKAmGFtZF9pb21tdV9p bml0X3Bhc3N0aHJvdWdo4oCZOgo+ICAgICBkcml2ZXJzL2lvbW11L2FtZF9pb21tdS5jOjM1MDM6 Njogd2FybmluZzogdW51c2VkIHZhcmlhYmxlIOKAmGRldmlk4oCZIFstV3VudXNlZC12YXJpYWJs ZV0KPiAgICAgICB1MTYgZGV2aWQ7Cj4gICAgICAgICAgIF4KPiAgICAgZHJpdmVycy9pb21tdS9h bWRfaW9tbXUuYzozNTAyOjIwOiB3YXJuaW5nOiB1bnVzZWQgdmFyaWFibGUg4oCYaW9tbXXigJkg Wy1XdW51c2VkLXZhcmlhYmxlXQo+ICAgICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11Owo+ICAg ICAgICAgICAgICAgICAgICAgICAgIF4KPiAKPiBJcyB0aGUgdHJpdmlhbCBmaXggZm9yIHRoaXMg cXVldWVkIHNvbWV3aGVyZT8KCkp1c3QgcXVldWVkIG9uZSB0byBteSB4ODYvYW1kIGJyYW5jaC4g VGhhbmtzIGZvciB0aGUgcmVwb3J0LgoKCglKb2VyZwoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5s aW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFp bG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934145AbaE3SVs (ORCPT ); Fri, 30 May 2014 14:21:48 -0400 Received: from 8bytes.org ([85.214.48.195]:43595 "EHLO mail.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933239AbaE3SVr (ORCPT ); Fri, 30 May 2014 14:21:47 -0400 Date: Fri, 30 May 2014 20:21:43 +0200 From: Joerg Roedel To: Paul Bolle Cc: Vaughan Cao , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remove duplicate checking code Message-ID: <20140530182143.GK17056@8bytes.org> References: <1400225980-12797-1-git-send-email-vaughan.cao@oracle.com> <20140526093959.GH17056@8bytes.org> <1401371147.22923.4.camel@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1401371147.22923.4.camel@x220> User-Agent: Mutt/1.5.21 (2010-09-15) X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Fri May 30 20:21:45 2014 X-DSPAM-Confidence: 0.9991 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 5388cc3920861616155294 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 29, 2014 at 03:45:47PM +0200, Paul Bolle wrote: > On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote: > > On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: > > > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device > > > called before, it's fine to attach device at this point. > > > > > > Signed-off-by: Vaughan Cao > > > --- > > > drivers/iommu/amd_iommu.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > Applied, thanks. > > This one entered linux-next, as of next-20142527, in commit ecef115d4540 > ("iommu/amd: Remove duplicate checking code"). It triggers an obviously > correct warning: > drivers/iommu/amd_iommu.c: In function ‘amd_iommu_init_passthrough’: > drivers/iommu/amd_iommu.c:3503:6: warning: unused variable ‘devid’ [-Wunused-variable] > u16 devid; > ^ > drivers/iommu/amd_iommu.c:3502:20: warning: unused variable ‘iommu’ [-Wunused-variable] > struct amd_iommu *iommu; > ^ > > Is the trivial fix for this queued somewhere? Just queued one to my x86/amd branch. Thanks for the report. Joerg