From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: John Crispin <blogic@openwrt.org>,
David Daney <ddaney@caviumnetworks.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH v2] MIPS: Implement random_get_entropy with CP0 Random
Date: Fri, 30 May 2014 21:18:08 +0200 [thread overview]
Message-ID: <20140530191808.GO5157@linux-mips.org> (raw)
In-Reply-To: <alpine.LFD.2.11.1404062102130.15266@eddie.linux-mips.org>
On Sun, Apr 06, 2014 at 09:31:29PM +0100, Maciej W. Rozycki wrote:
(Cc list chopped down to just the MIPS folks.)
> linux-mips-cycles.patch
> Index: linux-20140404-4maxp64/arch/mips/include/asm/timex.h
> ===================================================================
> --- linux-20140404-4maxp64.orig/arch/mips/include/asm/timex.h
> +++ linux-20140404-4maxp64/arch/mips/include/asm/timex.h
> @@ -4,15 +4,18 @@
> * for more details.
> *
> * Copyright (C) 1998, 1999, 2003 by Ralf Baechle
> + * Copyright (C) 2014 by Maciej W. Rozycki
> */
> #ifndef _ASM_TIMEX_H
> #define _ASM_TIMEX_H
>
> #ifdef __KERNEL__
>
> +#include <linux/compiler.h>
> +
> +#include <asm/cpu.h>
> #include <asm/cpu-features.h>
> #include <asm/mipsregs.h>
> -#include <asm/cpu-type.h>
And this line broke the build big time - lots of files are using either
boot_cpu_type() or current_cpu_type() and are implicitly getting the
definition via <asm/timex.h>.
So for the moment I've added the unnecessary inclusion of asm/cpu-type.h
back.
Ralf
next prev parent reply other threads:[~2014-05-30 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 20:31 [PATCH v2] MIPS: Implement random_get_entropy with CP0 Random Maciej W. Rozycki
2014-05-30 19:18 ` Ralf Baechle [this message]
2014-06-23 22:11 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530191808.GO5157@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=blogic@openwrt.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.