From: Greg KH <gregkh@linuxfoundation.org>
To: Scott Weir <sjw0410@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: fix Missing a blank line after declarations warnings
Date: Fri, 30 May 2014 21:19:48 -0700 [thread overview]
Message-ID: <20140531041948.GA10014@kroah.com> (raw)
In-Reply-To: <20140530055644.GA1782@lubuntuVM>
On Fri, May 30, 2014 at 03:56:44PM +1000, Scott Weir wrote:
> On Wed, May 28, 2014 at 02:30:27PM -0700, Greg KH wrote:
> > On Wed, May 28, 2014 at 06:52:51PM +1000, Scott Weir wrote:
> > > This patch corrects coding style issue:
> > > WARNING: Missing a black line after declarations
> > >
> > > Signed-off-by: Scott Weir <sjw0410@gmail.com>
> > > ---
> > > drivers/staging/android/sync_debug.c | 4 ++++
> >
> > This file isn't in my tree. Always work against linux-next, not Linus's
> > tree for new patches.
> >
> > thanks,
> >
> > greg k-h
>
> This patch was made against linux-next. Is it better to use your staging tree?
Yes, but normally it should also be fine to use linux-next.
I don't know where that sync_debug.c file is coming from, it's not in my
staging branch, some other tree must be creating it, which is
troublesome to me...
Anyway, sorry, but yes, work off of the staging-next branch of
staging.git on git.kernel.org and you should be fine.
thanks,
greg k-h
prev parent reply other threads:[~2014-05-31 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 8:52 [PATCH] staging: android: fix Missing a blank line after declarations warnings Scott Weir
2014-05-28 21:30 ` Greg KH
2014-05-30 5:56 ` Scott Weir
2014-05-31 4:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140531041948.GA10014@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sjw0410@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.