All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] graph-depends: refactor with more color
Date: Sat, 31 May 2014 21:50:39 +0200	[thread overview]
Message-ID: <20140531195039.GD3522@free.fr> (raw)
In-Reply-To: <1401564012-23822-1-git-send-email-francois.perrad@gadz.org>

Fran?ois, All,

On 2014-05-31 21:20 +0200, Francois Perrad spake thusly:
> target and host packages don't use the same background color

Interesting.

Since, I also have a series touching the graphs, I'll take your patch in
my series to do the appropriate transformations/adaptations.

Thanks!

Regards,
Yann E. MORIN.

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  support/scripts/graph-depends | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
> index e2a5e1e..443ac7d 100755
> --- a/support/scripts/graph-depends
> +++ b/support/scripts/graph-depends
> @@ -222,15 +222,22 @@ for dep in dependencies:
>  
>  # Print the attributes of a node: label and fill-color
>  def print_attrs(pkg):
> +    name = pkg_node_name(pkg)
>      if pkg == 'all':
> -        print "all [label = \"ALL\"]"
> -        print "all [color=lightblue,style=filled]"
> -        return
> -    print "%s [label = \"%s\"]" % (pkg_node_name(pkg), pkg)
> -    if mode == PKG_MODE and pkg == rootpkg:
> -        print "%s [color=lightblue,style=filled]" % pkg_node_name(rootpkg)
> +        label = 'ALL'
> +    else:
> +        label = pkg
> +    if pkg == 'all' or (mode == PKG_MODE and pkg == rootpkg):
> +        color = 'lightblue'
>      else:
> -        print "%s [color=grey,style=filled]" % pkg_node_name(pkg)
> +        if pkg.startswith('host') \
> +        or pkg.startswith('toolchain') \
> +        or pkg.startswith('rootfs'):
> +            color = 'gainsboro'
> +        else:
> +            color = 'grey'
> +    print "%s [label = \"%s\"]" % (name, label)
> +    print "%s [color=%s,style=filled]" % (name, color)
>  
>  # Print the dependency graph of a package
>  def print_pkg_deps(depth, pkg):
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-05-31 19:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31 19:20 [Buildroot] [PATCH] graph-depends: refactor with more color Francois Perrad
2014-05-31 19:50 ` Yann E. MORIN [this message]
2014-05-31 20:33 ` Yann E. MORIN
2014-06-01 13:23   ` François Perrad
2014-06-01 13:49     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140531195039.GD3522@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.