Re: [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line

["Michael S. Tsirkin" <mst@redhat.com>]

On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote:
>     Allow selection of different card models from the qemu
>     command line, to better accomodate a wider range of guests.

Looks good to me.
If possible pls address a nit I noted in one of the patches.
Besides that:

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>


> New in v3:
> 
>   - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with:
>       - s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan
>       - improved QOM-ification as suggested by Peter Crosthwaite
> 
>   - *OPTIONAL* patch to remove stale support for 8257xx (see commit blurb
>     in patch 3/3 for details
>     (this can be squashed on top of 1/3, but I'm including it separately
>      here for clarity, and as an RFC).
> 
> Thanks,
>   Gabriel
> 
> 
> v2:
> 
>   - moved check for 8257x out of the way of QOM, as suggested by
>     Michael (patch 1/3)
> 
>   - resolved "Signed-off-by" misunderstanding and miscellaneous style
>     issues (patch 2/3)
> 
>   - modified e1000 test to check for all supported models, as suggested
>     by Andreas (patch 3/3). I used eepro100-test.c as an example for
>     this change.
> 
> 
> Gabriel L. Somlo (3):
>   e1000: allow command-line selection of card model
>   tests: e1000: test additional device IDs
>   e1000: remove broken support for 82573L
> 
>  hw/net/e1000.c      | 110 +++++++++++++++++++++++++++++++++++++++-------------
>  hw/net/e1000_regs.h |   6 +++
>  tests/e1000-test.c  |  33 ++++++++++++----
>  3 files changed, 114 insertions(+), 35 deletions(-)
> 
> -- 
> 1.9.3