From: Patrick McHardy <kaber@trash.net>
To: Alvaro Neira Ayuso <alvaroneay@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nftables PATCH v2] src: Replace TOS support for using DSCP support
Date: Sun, 1 Jun 2014 21:27:07 +0100 [thread overview]
Message-ID: <20140601202707.GC19396@macbook.localnet> (raw)
In-Reply-To: <1401200300-24583-1-git-send-email-alvaroneay@gmail.com>
On Tue, May 27, 2014 at 04:18:20PM +0200, Alvaro Neira Ayuso wrote:
> From: Álvaro Neira Ayuso <alvaroneay@gmail.com>
>
> Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
> ---
> [changes in v2]
> * Replace TOS support for using DSCP support
>
> Now, when we add a rule with DSCP, in the code generation step, nftables
> compares 1 bytes but it should compare 6 bits. I think that the problem should
> be in the code generation.
I don't really see how this patch changes this. The kernel operates in units
of bytes. For anything smaller nftables will have to generate appropriate
bitwise operations. Please explain in more detail how this patch changes this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-01 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 10:00 [nftables PATCH 2/2] src: Add DSCP support in nftables Alvaro Neira Ayuso
2014-05-27 14:18 ` [nftables PATCH v2] src: Replace TOS support for using DSCP support Alvaro Neira Ayuso
2014-06-01 20:27 ` Patrick McHardy [this message]
2014-06-02 8:06 ` Álvaro Neira Ayuso
2014-06-02 8:58 ` Florian Westphal
2014-06-02 18:57 ` Álvaro Neira Ayuso
2014-06-03 5:26 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140601202707.GC19396@macbook.localnet \
--to=kaber@trash.net \
--cc=alvaroneay@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.