From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Xenia Ragiadakou <burzalodowa@gmail.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Ana Rey <anarey@gmail.com>, Teodora Baluta <teobaluta@gmail.com>,
Andrea Merello <andrea.merello@gmail.com>,
devel@driverdev.osuosl.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8192u: r8192U_core.c: Cleaning up uninitialized variables
Date: Mon, 2 Jun 2014 10:39:04 +0300 [thread overview]
Message-ID: <20140602073904.GQ17724@mwanda> (raw)
In-Reply-To: <CAFo99gZEDeXZvdmkESrQ0CSME4wEZ3WSEJmJ-FoJVXOhK=zzcQ@mail.gmail.com>
On Sun, Jun 01, 2014 at 11:05:39PM +0200, Rickard Strandqvist wrote:
> Hi Dan
>
> I agree, this looks strange.
> Have been looking for a while in history with, to see if the code has
> been removed. I start my search using cppcheck for over three months
> ago.
> But could not find anything. Sorry about that :-(
>
> But I'll make a patch that completely removes testing variable then instead?
Yes. Btw, what do the cppcheck error messages for this look like
anyway?
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-02 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 13:28 [PATCH] staging: rtl8192u: r8192U_core.c: Cleaning up uninitialized variables Rickard Strandqvist
2014-06-01 20:37 ` Dan Carpenter
2014-06-01 21:05 ` Rickard Strandqvist
2014-06-02 7:39 ` Dan Carpenter [this message]
2014-06-02 20:16 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602073904.GQ17724@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anarey@gmail.com \
--cc=andrea.merello@gmail.com \
--cc=burzalodowa@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.