Re: [ulogd PATCH 12/13] nfct: introduce new out keys for ipfix timestamp

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Sun, Jun 01, 2014 at 12:28:32PM +0200, Eric Leblond wrote:
> On Mon, 2014-04-28 at 20:56 +0900, Ken-ichirou MATSUZAWA wrote:
> > Signed-off-by Ken-ichirou MATSUZAWA <chamas@h4.dion.ne.jp>
> > ---
> >  input/flow/ulogd_inpflow_NFCT.c | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> > 
> > diff --git a/input/flow/ulogd_inpflow_NFCT.c b/input/flow/ulogd_inpflow_NFCT.c
> > index 4f4301e..b31c46f 100644
> > --- a/input/flow/ulogd_inpflow_NFCT.c
> > +++ b/input/flow/ulogd_inpflow_NFCT.c
> > @@ -186,8 +186,10 @@ enum nfct_keys {
> >  	NFCT_CT_EVENT,
> >  	NFCT_FLOW_START_SEC,
> >  	NFCT_FLOW_START_USEC,
> > +	NFCT_FLOW_START_MCSEC,

Perhaps you can consolidate this and provide just one single keys in
milliseconds?

> >  	NFCT_FLOW_END_SEC,
> >  	NFCT_FLOW_END_USEC,
> > +	NFCT_FLOW_END_MCSEC,
> >  	NFCT_OOB_FAMILY,
> >  	NFCT_OOB_PROTOCOL,
> >  	NFCT_CT,

It will just need to adapt other extensions to use it.