Re: [PATCH] drm/i915: enable PPGTT on VLV

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: enable PPGTT on VLV
Date: Mon, 2 Jun 2014 14:09:06 +0300	[thread overview]
Message-ID: <20140602110906.GW27580@intel.com> (raw)
In-Reply-To: <1401399201-1888-1-git-send-email-jbarnes@virtuousgeek.org>

On Thu, May 29, 2014 at 02:33:21PM -0700, Jesse Barnes wrote:
> Working for real this time.  i915_ppgtt_info has all sorts of good stuff
> in it and X is running nicely on top.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

So it wasn't just my vlv where it appears to work. That's nice.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bea9ab40..8631fb3 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1936,10 +1936,8 @@ struct drm_i915_cmd_table {
>  #define I915_NEED_GFX_HWS(dev)	(INTEL_INFO(dev)->need_gfx_hws)
>  
>  #define HAS_HW_CONTEXTS(dev)	(INTEL_INFO(dev)->gen >= 6)
> -#define HAS_ALIASING_PPGTT(dev)	(INTEL_INFO(dev)->gen >= 6 && \
> -				 (!IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev)))
> -#define HAS_PPGTT(dev)		(INTEL_INFO(dev)->gen >= 7 \
> -				 && !IS_GEN8(dev))
> +#define HAS_ALIASING_PPGTT(dev)	(INTEL_INFO(dev)->gen >= 6)
> +#define HAS_PPGTT(dev)		(INTEL_INFO(dev)->gen >= 7 && !IS_GEN8(dev))
>  #define USES_PPGTT(dev)		intel_enable_ppgtt(dev, false)
>  #define USES_FULL_PPGTT(dev)	intel_enable_ppgtt(dev, true)
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC