All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Church <sleeveroller@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, lisa@xenapiadmin.com,
	bergwolf@gmail.com, andreas.dilger@intel.com,
	oleg.drokin@intel.com, doug.s.oucharek@intel.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: fix sparse warnings for undeclared symbols
Date: Mon, 2 Jun 2014 14:14:45 +0100	[thread overview]
Message-ID: <20140602131443.GA3983@gmail.com> (raw)
In-Reply-To: <20140602121918.GZ15585@mwanda>

On Mon, Jun 02, 2014 at 03:19:18PM +0300, Dan Carpenter wrote:
> 
> Why not just make them static?  They don't seem to be used outside of
> that file.  What am I missing?
> 

Given a 50/50 choice I based my decision on the surrounding functions which were mostly defined in the header file.

I should have done a little more invstigation which would have led me to the opposite conclusion.

I will redo them as static and resumbit.

Thanks for your help Dan.

Regards,
John

  reply	other threads:[~2014-06-02 13:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 12:03 [PATCH] staging: lustre: fix sparse warnings for undeclared symbols John Church
2014-06-02 12:19 ` Dan Carpenter
2014-06-02 13:14   ` John Church [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-06-02 13:31 John Church
2014-06-16 10:44 [PATCH] staging: lustre: Fix " Scott Weir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140602131443.GA3983@gmail.com \
    --to=sleeveroller@gmail.com \
    --cc=andreas.dilger@intel.com \
    --cc=bergwolf@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=doug.s.oucharek@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa@xenapiadmin.com \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.