Re: [PATCH] Allow user-defined functions to override builtins.

[Andrey Borzenkov <arvidjaar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]

В Tue, 27 May 2014 01:27:47 -0500
Glenn Washburn <development@efficientek.com> пишет:

> On Sun, 25 May 2014 05:03:31 +0200
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> wrote:
> 
> > On 24.05.2014 09:47, Glenn Washburn wrote:
> > > But the prefix variable is used for other things in the loaded
> > > config file.  So if I change the prefix to be that of the running
> > > grub to load the correct modules, other parts of the config will
> > > break (for instance, loading fonts or locales).
> > Localesneed to come from folder matching running GRUB, otherwise
> > you'll get string mismatches. Fonts typically come from themes or is
> > unifont.
> > 
> > Additionally your approach doesn't solve the problem in the first
> > place. insmod is just one of possible ways to load modules. For
> > various autoloads there is no command to hook.
> 
> I'm not sure of a good solution to the locale problem, but I don't
> think I've run in to it (I use english, which I don't think needs
> them).  So ignore my comment about locales.
> 
> As far as module auto-loading, please correct me if I'm wrong, but I
> think auto-loading mostly happens when resolving dependencies when
> loading another module.  I have seen, for instance, the "help loadfont"
> command auto-load the font modules, but in what other situations does
> modules auto-loading occur?
> 

Every time you use any command that is defined in a module. Or use
hashing/encryption algorithm. Or ... actually most of grub is
auto-loaded on demand.

> In my case, I think things generally work because auto-loading is
> happening as a reaction to an explicit load from insmod.  In this
> context things will work as desired because the changed prefix set in
> the insmod hook will be used.
> 
> Michel also had a good use for it, which is to provide cheap builtin
> trace/logging.  I expect as grub gets more powerful more uses not
> thought of will crop up.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]