From: Oleg Nesterov <oleg@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Denys Vlasenko <dvlasenk@redhat.com>,
Hugh Dickins <hughd@google.com>,
Jim Keniston <jkenisto@us.ibm.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] uprobes: tmpfs support
Date: Mon, 2 Jun 2014 21:23:44 +0200 [thread overview]
Message-ID: <20140602192344.GA30792@redhat.com> (raw)
In-Reply-To: <20140602183028.GA9372@infradead.org>
On 06/02, Christoph Hellwig wrote:
>
> On Mon, Jun 02, 2014 at 04:14:06PM +0200, Oleg Nesterov wrote:
> > Ingo, please pull from
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core
> >
> > Based on tip:perf/uprobes
>
> Eww, adding tmpfs-specific code to uprobes screams layering violation.
>
> Hugh, what is the problem with implementing ->readpage for tmpfs again?
I leave this to you and Hugh.
But I hope you are not arguing with this patch, it is very simple and we
do want to support tmpfs. If tmpfs has ->readpage again we can revert this
patch.
BTW. Is it safe to pass file == NULL to read_mapping_page() and ->readpage()?
Last time I tried to check this looked safe but this is not documented. We
need to call read_mapping_page() from uprobe_register() but it doesn't have
"struct file *" and thus we need to delay arch_uprobe_analyze_insn() until
we find the first mapping, too bad.
And why read_mapping_page() has "void *data" but not "struct file *file"...
Oleg.
prev parent reply other threads:[~2014-06-02 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 14:14 [GIT PULL] uprobes: tmpfs support Oleg Nesterov
2014-06-02 18:30 ` Christoph Hellwig
2014-06-02 19:09 ` Hugh Dickins
2014-06-02 19:23 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602192344.GA30792@redhat.com \
--to=oleg@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.