From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WraPo-00042S-Hh for qemu-devel@nongnu.org; Mon, 02 Jun 2014 18:09:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WraPj-0002j2-PO for qemu-devel@nongnu.org; Mon, 02 Jun 2014 18:09:12 -0400 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:44031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WraPj-0002il-IQ for qemu-devel@nongnu.org; Mon, 02 Jun 2014 18:09:07 -0400 Received: by mail-wi0-f177.google.com with SMTP id f8so5437998wiw.16 for ; Mon, 02 Jun 2014 15:09:06 -0700 (PDT) Date: Mon, 2 Jun 2014 23:09:02 +0100 From: Hani Benhabiles Message-ID: <20140602220902.GB5283@Inspiron-3521> References: <1401572382-11667-1-git-send-email-kroosec@gmail.com> <1401572382-11667-2-git-send-email-kroosec@gmail.com> <20140602123206.GF3049@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140602123206.GF3049@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/3] nbd: Handle fixed new-style clients. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Mon, Jun 02, 2014 at 02:32:06PM +0200, Stefan Hajnoczi wrote: > On Sat, May 31, 2014 at 10:39:40PM +0100, Hani Benhabiles wrote: > > Signed-off-by: Hani Benhabiles > > --- > > include/block/nbd.h | 6 ++++++ > > nbd.c | 12 +++++++----- > > 2 files changed, 13 insertions(+), 5 deletions(-) > > No explanation or link to specification for this new flag field? What's > different about a new-style client? With this flag is set, the server tells the client that it can send another option if the server got a request with an option it doesn't understand (instead of the server closing the connection.) Thus, the while(1) loop in 2/3. The kernel in Documentation/blockdev/nbd.txt points to the NBD project for documentation. The proto documentation is in [1]. Shouldn't Qemu also do the same ? [1] https://github.com/yoe/nbd/blob/master/doc/proto.txt