All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jianyu Zhan <nasa4836@gmail.com>
Subject: Re: 3.15 regression: wrong cgroup magic
Date: Mon, 2 Jun 2014 21:22:11 -0400	[thread overview]
Message-ID: <20140603012211.GE19855@htj.dyndns.org> (raw)
In-Reply-To: <538D2261.70406@huawei.com>

On Tue, Jun 03, 2014 at 09:18:25AM +0800, Li Zefan wrote:
> > commit 2bd59d48ebfb3df41ee56938946ca0dd30887312
> > Author: Tejun Heo <tj@kernel.org>
> > Date:   Tue Feb 11 11:52:49 2014 -0500
> > 
> >     cgroup: convert to kernfs
> > 
> > In particular, this piece:
> > 
> > -       sb->s_magic = CGROUP_SUPER_MAGIC;
> > 
> > The result is that cgroup shows up with the wrong magic number, so my
> > code goes "oh crap, cgroupfs isn't mounted" and fails.
> > 
> > I can change my code to hack around this, but I can imagine other
> > things getting tripped up.  Is there still time to fix this?
> > 
> 
> This should be fixed by "kernfs: move the last knowledge of sysfs out from kernfs".
> 
> It's in driver-core-next.
> 
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=26fc9cd200ec839e0b3095e05ae018f27314e7aa

Right, I was writing about the same patch with a nagging sense of
deja-vu.  I should have noticed that this must go through
driver-core-linus not -next.  Sorry about that.

Linus, can you please cherry-pick the commit?

Thanks.

-- 
tejun

  reply	other threads:[~2014-06-03  1:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03  0:56 3.15 regression: wrong cgroup magic Andy Lutomirski
2014-06-03  1:15 ` Linus Torvalds
2014-06-03  1:18 ` Li Zefan
2014-06-03  1:22   ` Tejun Heo [this message]
2014-06-03  1:30     ` Linus Torvalds
2014-06-03  4:26       ` Greg Kroah-Hartman
2014-06-03 17:23       ` Linus Torvalds
2014-06-03 17:48         ` Andy Lutomirski
2014-06-03 17:49           ` Linus Torvalds
2014-06-03 17:52         ` Tejun Heo
2014-06-03 17:53           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140603012211.GE19855@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=luto@amacapital.net \
    --cc=nasa4836@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.