From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] ARM: i.MX: Compile FIQ code for AVIC & TZIC only Date: Tue, 3 Jun 2014 15:37:04 +0800 Message-ID: <20140603073702.GP8860@dragon> References: <1400604231-2672-1-git-send-email-shc_work@mail.ru> <1400604231-2672-2-git-send-email-shc_work@mail.ru> <20140602113327.2568c198@ipc1.ka-ro> <1401702163.832576877@f354.i.mail.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2lp0238.outbound.protection.outlook.com [207.46.163.238]) by alsa0.perex.cz (Postfix) with ESMTP id EEFA12655C5 for ; Tue, 3 Jun 2014 09:37:26 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1401702163.832576877@f354.i.mail.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Alexander Shiyan Cc: alsa-devel@alsa-project.org, Timur Tabi , linux-arm-kernel@lists.infradead.org, Sascha Hauer , Lothar =?iso-8859-1?Q?Wa=DFmann?= List-Id: alsa-devel@alsa-project.org T24gTW9uLCBKdW4gMDIsIDIwMTQgYXQgMDE6NDI6NDNQTSArMDQwMCwgQWxleGFuZGVyIFNoaXlh biB3cm90ZToKPiBNb24sIDIgSnVuIDIwMTQgMTE6MzM6MjcgKzAyMDAg0L7RgiBMb3RoYXIgV2HD n21hbm4gPExXQEtBUk8tZWxlY3Ryb25pY3MuZGU+Ogo+ID4gSGksCj4gPiAKPiA+IEFsZXhhbmRl ciBTaGl5YW4gd3JvdGU6Cj4gPiA+IFRoZXJlIGFyZSBubyByZWFzb24gdG8gY29tcGlsZSBGSVEg c3BlY2lmaWMgY29kZSBmb3IgR0lDIElSUQo+ID4gPiBjb250cm9sbGVyIChpLk1YNikuIFRoaXMg cGF0Y2ggcmVzdHJpY3QgY29tcGlsYXRpb24gZm9yIEZJUQo+ID4gPiBzcGVjaWZpYyBjb2RlIGZv ciBBVklDIGFuZCBUWklDIG9ubHkuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBBbGV4YW5k ZXIgU2hpeWFuIDxzaGNfd29ya0BtYWlsLnJ1Pgo+ID4gPiAtLS0KPiA+ID4gIGFyY2gvYXJtL21h Y2gtaW14L01ha2VmaWxlIHwgNiArKystLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2Vy dGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9h cm0vbWFjaC1pbXgvTWFrZWZpbGUgYi9hcmNoL2FybS9tYWNoLWlteC9NYWtlZmlsZQo+ID4gPiBp bmRleCBiYmU5M2JiLi42MjBhNzYwIDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL2FybS9tYWNoLWlt eC9NYWtlZmlsZQo+ID4gPiArKysgYi9hcmNoL2FybS9tYWNoLWlteC9NYWtlZmlsZQo+ID4gPiBA QCAtMSw0ICsxLDQgQEAKPiA+ID4gLW9iai15IDo9IHRpbWUubyBjcHUubyBzeXN0ZW0ubyBpcnEt Y29tbW9uLm8KPiA+ID4gK29iai15IDo9IHRpbWUubyBjcHUubyBzeXN0ZW0ubwo+ID4gPiAgCj4g PiA+ICBvYmotJChDT05GSUdfU09DX0lNWDEpICs9IGNsay1pbXgxLm8gbW0taW14MS5vCj4gPiA+ ICBvYmotJChDT05GSUdfU09DX0lNWDIxKSArPSBjbGstaW14MjEubyBtbS1pbXgyMS5vCj4gPiA+ IEBAIC0yMSw4ICsyMSw4IEBAIG9iai0kKENPTkZJR19DT01NT05fQ0xLKSArPSBjbGstcGxsdjEu byBjbGstcGxsdjIubyBjbGstcGxsdjMubyBjbGstZ2F0ZTIubyBcCj4gPiA+ICBvYmotJChDT05G SUdfSU1YX0hBVkVfSU9NVVhfVjEpICs9IGlvbXV4LXYxLm8KPiA+ID4gIG9iai0kKENPTkZJR19B UkNIX01YQ19JT01VWF9WMykgKz0gaW9tdXgtdjMubwo+ID4gPiAgCj4gPiA+IC1vYmotJChDT05G SUdfTVhDX1RaSUMpICs9IHR6aWMubwo+ID4gPiAtb2JqLSQoQ09ORklHX01YQ19BVklDKSArPSBh dmljLm8KPiA+ID4gK29iai0kKENPTkZJR19NWENfVFpJQykgKz0gdHppYy5vIGlycS1jb21tb24u bwo+ID4gPiArb2JqLSQoQ09ORklHX01YQ19BVklDKSArPSBhdmljLm8gaXJxLWNvbW1vbi5vCj4g PiA+ICAKPiA+ID4gIG9iai0kKENPTkZJR19NWENfVVNFX0VQSVQpICs9IGVwaXQubwo+ID4gPiAg b2JqLSQoQ09ORklHX01YQ19ERUJVR19CT0FSRCkgKz0gM2RzX2RlYnVnYm9hcmQubwo+ID4gPgo+ ID4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGEgYnVpbGQgZXJyb3IgaW4gc291bmQvc29jL2ZzbC9p bXgtcGNtLWZpcS5jOgo+ID4gc291bmQvYnVpbHQtaW4ubzogSW4gZnVuY3Rpb24gYGlteF9wY21f ZmlxX2ZyZWUnOgo+ID4gbGFzdC5jOigudGV4dCsweDJhY2E4KTogdW5kZWZpbmVkIHJlZmVyZW5j ZSB0byBgbXhjX3NldF9pcnFfZmlxJwo+ID4gc291bmQvYnVpbHQtaW4ubzogSW4gZnVuY3Rpb24g YGlteF9wY21fZmlxX2luaXQnOgo+ID4gbGFzdC5jOigudGV4dCsweDJiMWE0KTogdW5kZWZpbmVk IHJlZmVyZW5jZSB0byBgbXhjX3NldF9pcnFfZmlxJwo+ID4gbGFzdC5jOigudGV4dCsweDJiMjAw KTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgbXhjX3NldF9pcnFfZmlxJwo+ID4gbWFrZVsxXTog KioqIFt2bWxpbnV4XSBFcnJvciAxCj4gPiBtYWtlOiAqKiogW3N1Yi1tYWtlXSBFcnJvciAyCj4g PiAKPiA+IFRoaXMgY291bGQgYmUgZml4ZWQgd2l0aCB0aGUgZm9sbG93aW5nIHBhdGNoOgo+ID4g LS0tIG14Yy1maXEub3JpZy9zb3VuZC9zb2MvZnNsL0tjb25maWcgIDIwMTQtMDYtMDIgMTE6MjU6 MzguMzE1OTYwNDUxICswMjAwCj4gPiArKysgbXhjLWZpcS9zb3VuZC9zb2MvZnNsL0tjb25maWcg ICAgICAgMjAxNC0wNi0wMiAxMToyNTozOC40MTE5NjA1OTUgKzAyMDAKPiA+IEBAIC0xNSw3ICsx NSw3IEBACj4gPiAgY29uZmlnIFNORF9TT0NfRlNMX1NTSQo+ID4gCXRyaXN0YXRlICJTeW5jaHJv bm91cyBTZXJpYWwgSW50ZXJmYWNlIG1vZHVsZSBzdXBwb3J0Igo+ID4gCXNlbGVjdCBTTkRfU09D X0lNWF9QQ01fRE1BIGlmIFNORF9JTVhfU09DICE9IG4KPiA+IC0Jc2VsZWN0IFNORF9TT0NfSU1Y X1BDTV9GSVEgaWYgU05EX0lNWF9TT0MgIT0gbiAmJiBBUkNIX01YQwo+ID4gKwlzZWxlY3QgU05E X1NPQ19JTVhfUENNX0ZJUSBpZiBTTkRfSU1YX1NPQyAhPSBuICYmIChNWENfQVZJQyB8fCBNWENf VFpJQykKPiAuLi4KPiAKPiBOby4gVGhpcyB3aWxsIGJyZWFrIGJ1aWxkaW5nIGZzbC1zc2kgZm9y IFBQQyBhbmQgaS5NWDYsIHNvIGxldCdzIGp1c3QgZHJvcCBvcmlnaW5hbCBwYXRjaCBmb3IgYSB3 aGlsZS4KCk9rLCBwYXRjaCBkcm9wcGVkIGZvciBub3cuCgpTaGF3bgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApB bHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.guo@freescale.com (Shawn Guo) Date: Tue, 3 Jun 2014 15:37:04 +0800 Subject: [PATCH] ARM: i.MX: Compile FIQ code for AVIC & TZIC only In-Reply-To: <1401702163.832576877@f354.i.mail.ru> References: <1400604231-2672-1-git-send-email-shc_work@mail.ru> <1400604231-2672-2-git-send-email-shc_work@mail.ru> <20140602113327.2568c198@ipc1.ka-ro> <1401702163.832576877@f354.i.mail.ru> Message-ID: <20140603073702.GP8860@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 02, 2014 at 01:42:43PM +0400, Alexander Shiyan wrote: > Mon, 2 Jun 2014 11:33:27 +0200 ?? Lothar Wa?mann : > > Hi, > > > > Alexander Shiyan wrote: > > > There are no reason to compile FIQ specific code for GIC IRQ > > > controller (i.MX6). This patch restrict compilation for FIQ > > > specific code for AVIC and TZIC only. > > > > > > Signed-off-by: Alexander Shiyan > > > --- > > > arch/arm/mach-imx/Makefile | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile > > > index bbe93bb..620a760 100644 > > > --- a/arch/arm/mach-imx/Makefile > > > +++ b/arch/arm/mach-imx/Makefile > > > @@ -1,4 +1,4 @@ > > > -obj-y := time.o cpu.o system.o irq-common.o > > > +obj-y := time.o cpu.o system.o > > > > > > obj-$(CONFIG_SOC_IMX1) += clk-imx1.o mm-imx1.o > > > obj-$(CONFIG_SOC_IMX21) += clk-imx21.o mm-imx21.o > > > @@ -21,8 +21,8 @@ obj-$(CONFIG_COMMON_CLK) += clk-pllv1.o clk-pllv2.o clk-pllv3.o clk-gate2.o \ > > > obj-$(CONFIG_IMX_HAVE_IOMUX_V1) += iomux-v1.o > > > obj-$(CONFIG_ARCH_MXC_IOMUX_V3) += iomux-v3.o > > > > > > -obj-$(CONFIG_MXC_TZIC) += tzic.o > > > -obj-$(CONFIG_MXC_AVIC) += avic.o > > > +obj-$(CONFIG_MXC_TZIC) += tzic.o irq-common.o > > > +obj-$(CONFIG_MXC_AVIC) += avic.o irq-common.o > > > > > > obj-$(CONFIG_MXC_USE_EPIT) += epit.o > > > obj-$(CONFIG_MXC_DEBUG_BOARD) += 3ds_debugboard.o > > > > > This patch introduces a build error in sound/soc/fsl/imx-pcm-fiq.c: > > sound/built-in.o: In function `imx_pcm_fiq_free': > > last.c:(.text+0x2aca8): undefined reference to `mxc_set_irq_fiq' > > sound/built-in.o: In function `imx_pcm_fiq_init': > > last.c:(.text+0x2b1a4): undefined reference to `mxc_set_irq_fiq' > > last.c:(.text+0x2b200): undefined reference to `mxc_set_irq_fiq' > > make[1]: *** [vmlinux] Error 1 > > make: *** [sub-make] Error 2 > > > > This could be fixed with the following patch: > > --- mxc-fiq.orig/sound/soc/fsl/Kconfig 2014-06-02 11:25:38.315960451 +0200 > > +++ mxc-fiq/sound/soc/fsl/Kconfig 2014-06-02 11:25:38.411960595 +0200 > > @@ -15,7 +15,7 @@ > > config SND_SOC_FSL_SSI > > tristate "Synchronous Serial Interface module support" > > select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n > > - select SND_SOC_IMX_PCM_FIQ if SND_IMX_SOC != n && ARCH_MXC > > + select SND_SOC_IMX_PCM_FIQ if SND_IMX_SOC != n && (MXC_AVIC || MXC_TZIC) > ... > > No. This will break building fsl-ssi for PPC and i.MX6, so let's just drop original patch for a while. Ok, patch dropped for now. Shawn