From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 03 Jun 2014 11:34:39 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:44171 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6843095AbaFCJehTHv17 (ORCPT ); Tue, 3 Jun 2014 11:34:37 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.7/8.14.4) with ESMTP id s539YZ20024564; Tue, 3 Jun 2014 11:34:35 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.7/8.14.7/Submit) id s539YYHr024563; Tue, 3 Jun 2014 11:34:34 +0200 Date: Tue, 3 Jun 2014 11:34:34 +0200 From: Ralf Baechle To: Markos Chandras Cc: linux-mips@linux-mips.org Subject: Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive Message-ID: <20140603093434.GQ17197@linux-mips.org> References: <1401785177-7904-1-git-send-email-markos.chandras@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401785177-7904-1-git-send-email-markos.chandras@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 40412 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Jun 03, 2014 at 09:46:17AM +0100, Markos Chandras wrote: > Warning: the 32-bit microMIPS architecture does not support the `smartmips' > extension > arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24' > [...] > arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24' > > Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021 > Reviewed-by: Steven J. Hill > Signed-off-by: Markos Chandras > --- > arch/mips/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 2fe8e60..ffde3d6 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT > def_bool 64BIT_PHYS_ADDR > > config CPU_HAS_SMARTMIPS > - depends on SYS_SUPPORTS_SMARTMIPS > + depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS > bool "Support for the SmartMIPS ASE" > help > SmartMIPS is a extension of the MIPS32 architecture aimed at >From a user's perspective that's a bit quirky; a user has to first disable CPU_MICROMIPS before he can enable CPU_HAS_SMARTMIPS. So I think this should become a choice statement. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from localhost.localdomain ([127.0.0.1]:44171 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6843095AbaFCJehTHv17 (ORCPT ); Tue, 3 Jun 2014 11:34:37 +0200 Date: Tue, 3 Jun 2014 11:34:34 +0200 From: Ralf Baechle Subject: Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive Message-ID: <20140603093434.GQ17197@linux-mips.org> References: <1401785177-7904-1-git-send-email-markos.chandras@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401785177-7904-1-git-send-email-markos.chandras@imgtec.com> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Markos Chandras Cc: linux-mips@linux-mips.org Message-ID: <20140603093434.UJPMnY13rDNndm5WWd6dwi0CpfeUxOnhnKNTr7WZ6gA@z> On Tue, Jun 03, 2014 at 09:46:17AM +0100, Markos Chandras wrote: > Warning: the 32-bit microMIPS architecture does not support the `smartmips' > extension > arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24' > [...] > arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24' > > Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021 > Reviewed-by: Steven J. Hill > Signed-off-by: Markos Chandras > --- > arch/mips/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 2fe8e60..ffde3d6 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT > def_bool 64BIT_PHYS_ADDR > > config CPU_HAS_SMARTMIPS > - depends on SYS_SUPPORTS_SMARTMIPS > + depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS > bool "Support for the SmartMIPS ASE" > help > SmartMIPS is a extension of the MIPS32 architecture aimed at