From: Frederic Weisbecker <fweisbec@gmail.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jacob Shin <jacob.w.shin@gmail.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
xiakaixu <xiakaixu@huawei.com>
Subject: Re: [PATCH 1/4] perf/x86/amd: AMD support for bp_len > HW_BREAKPOINT_LEN_8
Date: Tue, 3 Jun 2014 17:37:23 +0200 [thread overview]
Message-ID: <20140603153721.GD23860@localhost.localdomain> (raw)
In-Reply-To: <538936AB.9000005@amd.com>
On Fri, May 30, 2014 at 08:55:55PM -0500, Suravee Suthikulpanit wrote:
>
>
> On 05/30/2014 08:33 AM, Frederic Weisbecker wrote:
> >>diff --git a/arch/x86/include/asm/debugreg.h b/arch/x86/include/asm/debugreg.h
> >>>index 4b528a9..145b009 100644
> >>>--- a/arch/x86/include/asm/debugreg.h
> >>>+++ b/arch/x86/include/asm/debugreg.h
> >>>@@ -114,5 +114,10 @@ static inline void debug_stack_usage_inc(void) { }
> >>> static inline void debug_stack_usage_dec(void) { }
> >>> #endif /* X86_64 */
> >>>
> >>>+#ifdef CONFIG_CPU_SUP_AMD
> >>>+extern void set_dr_addr_mask(unsigned long mask, int dr);
> >>>+#else
> >>>+static inline void set_dr_addr_mask(unsigned long mask, int dr) { }
> >>>+#endif
> >I see this symbol in the code but it's not defined anywhere in a Kconfig file.
> >Maybe you (or I) forgot to include a file in your patches?
> >
> >Thanks.
>
> If you are referring to the CONFIG_CPU_SUP_AMD, this is in
> arch/x86/Kconfig.cpu
Ah I thought it was created in the patchset. Nevermind.
next prev parent reply other threads:[~2014-06-03 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 15:26 [PATCH 0/4] perf: Support AMD range breakpoints Frederic Weisbecker
2014-05-29 15:26 ` [PATCH 1/4] perf/x86/amd: AMD support for bp_len > HW_BREAKPOINT_LEN_8 Frederic Weisbecker
2014-05-30 13:33 ` Frederic Weisbecker
2014-05-31 1:55 ` Suravee Suthikulpanit
2014-06-03 15:37 ` Frederic Weisbecker [this message]
2014-05-29 15:26 ` [PATCH 2/4] perf tools: allow user to specify hardware breakpoint bp_len Frederic Weisbecker
2014-05-30 13:39 ` Jiri Olsa
2014-06-03 1:36 ` Namhyung Kim
2014-06-03 11:55 ` Jiri Olsa
2014-06-06 16:30 ` Suravee Suthikulanit
2014-08-04 19:27 ` Suravee Suthikulanit
2014-05-29 15:26 ` [PATCH 3/4] perf tools: add hardware breakpoint bp_len test cases Frederic Weisbecker
2014-05-30 14:49 ` Suravee Suthikulanit
2014-05-30 15:24 ` Frederic Weisbecker
2014-05-29 15:26 ` [PATCH 4/4] perf/x86: Remove get_hbp_len and replace with bp_len Frederic Weisbecker
2014-05-30 13:06 ` [PATCH 0/4] perf: Support AMD range breakpoints Jiri Olsa
2014-06-01 18:06 ` Suravee Suthikulpanit
-- strict thread matches above, loose matches on Subject: below --
2014-12-04 0:13 [GIT PULL][RESEND] hw_breakpoints: " Frederic Weisbecker
2014-12-04 0:13 ` [PATCH 1/4] perf/x86/amd: AMD support for bp_len > HW_BREAKPOINT_LEN_8 Frederic Weisbecker
2014-10-01 21:37 [GIT PULL] hw_breakpoints: Support AMD range breakpoints Frederic Weisbecker
2014-10-01 21:37 ` [PATCH 1/4] perf/x86/amd: AMD support for bp_len > HW_BREAKPOINT_LEN_8 Frederic Weisbecker
2014-09-24 13:45 [PATCH 0/4] perf: Support AMD range breakpoints v2 Frederic Weisbecker
2014-09-24 13:45 ` [PATCH 1/4] perf/x86/amd: AMD support for bp_len > HW_BREAKPOINT_LEN_8 Frederic Weisbecker
2013-12-11 12:28 [PATCH V6 0/4] perf/x86/amd: AMD Family 16h Data Breakpoint Extensions suravee.suthikulpanit
2013-12-11 12:28 ` [PATCH 1/4] perf/x86/amd: AMD support for bp_len > HW_BREAKPOINT_LEN_8 suravee.suthikulpanit
2014-01-09 1:24 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603153721.GD23860@localhost.localdomain \
--to=fweisbec@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=jacob.w.shin@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.