Re: [PATCH 3/5] arago-prefs: make ARAGO_QT_PROVIDER aware of Qt5

[Denys Dmytriyenko <denys@ti.com>]

On Tue, Jun 03, 2014 at 02:48:12PM +0000, Cooper Jr., Franklin wrote:
> Currently we also use ARAGO_QT_PROVIDER to determine if we need to include 
> GLES based applications or not specifically quick-playground.

Right now GLES side of Qt5 apps is not complete and quick-playground is not 
ported, so it doesn't make any difference. Once more and more apps are ported 
to Qt5, we can look into that.


> We also use it to set QT_SGX_SUPPORT in 
> packagegroup-arago-qte-toolchain-target.bb and packagegroup-arago-qte.bb so 
> maybe we need to pull this variable to arago-prefs.inc make it a boolean 
> variable. This way we can still conditional set it to TRUE depending on the 
> Qt 4 version we are using and always set it to true for Qt 5.

Those packagegroups are Qt4 specific and it's still Ok to use that variable 
for that purpose. Those packagegroups won't be included when building with Qt5


> Once we fixup the QT_SGX_SUPPORT variable then we can use that variable to 
> determine if a gles application should be pulled in or not.
> 
> 
> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > Sent: Monday, June 02, 2014 9:30 PM
> > To: meta-arago@arago-project.org
> > Subject: [meta-arago] [PATCH 3/5] arago-prefs: make ARAGO_QT_PROVIDER
> > aware of Qt5
> > 
> > From: Denys Dmytriyenko <denys@ti.com>
> > 
> > As ARAGO_QT_PROVIDER is used to select between gles and non-gles versions
> > of Qt4, make it aware of Qt5 and set it empty in that case.
> > 
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  meta-arago-distro/conf/distro/include/arago-prefs.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-arago-distro/conf/distro/include/arago-prefs.inc b/meta-
> > arago-distro/conf/distro/include/arago-prefs.inc
> > index 6ae11e9..0885acf 100644
> > --- a/meta-arago-distro/conf/distro/include/arago-prefs.inc
> > +++ b/meta-arago-distro/conf/distro/include/arago-prefs.inc
> > @@ -25,7 +25,7 @@ PREFERRED_VERSION_libdrm = "2.4.46"
> > 
> >  PREFERRED_PROVIDER_virtual/gettext = "gettext"
> > 
> > -ARAGO_QT_PROVIDER = "${@base_contains('MACHINE_FEATURES','sgx','qt4-
> > embedded-gles','qt4-embedded',d)}"
> > +ARAGO_QT_PROVIDER =
> > "${@base_contains('QT_PROVIDER','qt5','',base_contains('MACHINE_FEATURES
> > ','sgx','qt4-embedded-gles','qt4-embedded',d),d)}"
> >  PREFERRED_PROVIDER_qt4-embedded = "${ARAGO_QT_PROVIDER}"
> > 
> >  PREFERRED_VERSION_qt4-embedded = "4.8.5"
> > --
> > 1.9.2
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago