From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: dm: disable WRITE SAME if it fails Date: Tue, 3 Jun 2014 20:06:09 -0400 Message-ID: <20140604000609.GA10208@redhat.com> References: <53042F91.4050201@huawei.com> <53899812.50403@huawei.com> <20140531150517.GJ29705@agk-dp.fab.redhat.com> <20140602183635.GA1396@redhat.com> <20140603165859.GA8091@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: "Martin K. Petersen" Cc: Kiyoshi Ueda , Milan Broz , Mike Anderson , christophe varoqui , alex chen , device-mapper development , Jun'ichi Nomura , Joseph Qi , Alasdair Kergon List-Id: dm-devel.ids On Tue, Jun 03 2014 at 6:59pm -0400, Martin K. Petersen wrote: > >>>>> "Mike" == Mike Snitzer writes: > > >> > Shouldn't this code be taken out of mpath and moved to dm.c and > >> > applied to all targets (both bio and rq-based, at least where WRITE > >> > SAME is supported)? > > Mike> FYI, I pushed a revised version of this patch to linux-next, > > I haven't tested the patch but I definitely agree with this approach. > > Acked-by: Martin K. Petersen Thanks, added.