All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	lee.jones@linaro.org, lgirdwood@gmail.com, sameo@linux.intel.com
Subject: Re: [PATCH] ASoC: arizona: Implement TDM support for Arizona	devices
Date: Wed, 4 Jun 2014 09:08:08 +0100	[thread overview]
Message-ID: <20140604080808.GG11951@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140603220607.GD2520@sirena.org.uk>

On Tue, Jun 03, 2014 at 11:06:07PM +0100, Mark Brown wrote:
> On Tue, Jun 03, 2014 at 08:06:10PM +0100, Charles Keepax wrote:
> 
> > +	if (tdm_width && wl != tdm_width)
> > +		arizona_aif_warn(dai, "Word length not equal to TDM width\n");
> > +
> 
> Is it a problem to have say 16 bit words in a 32 bit TDM slot?  One of
> the reasons this stuff sometimes gets used is to help out the other
> connected device if it's having trouble configuring the "natural" clock
> rates.  Ignoring LSBs shouldn't be an issue.

A good point I will respin and take this out.

Thanks,
Charles

      reply	other threads:[~2014-06-04  8:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 19:06 [PATCH] ASoC: arizona: Implement TDM support for Arizona devices Charles Keepax
2014-06-03 22:06 ` Mark Brown
2014-06-04  8:08   ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140604080808.GG11951@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.