From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/7] ACPICA: Only include ACPI asm files if ACPI is enabled Date: Wed, 4 Jun 2014 13:51:37 +0100 Message-ID: <20140604125137.GA18171@lee--X1> References: <1401883796-17841-1-git-send-email-lee.jones@linaro.org> <1401883796-17841-2-git-send-email-lee.jones@linaro.org> <3061297.feg5DGUjIt@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <3061297.feg5DGUjIt-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Lv Zheng , "Rafael J. Wysocki" , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-E0kO6a4B6psdnm+yROfE0A@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Wed, 04 Jun 2014, Rafael J. Wysocki wrote: > On Wednesday, June 04, 2014 01:09:50 PM Lee Jones wrote: > > Any drivers which support ACPI and Device Tree probing need to incl= ude > > both respective header files. Without this patch, if a driver is b= eing > > used on a platform which does not support ACPI and subsequently doe= s not > > have the config option enabled, but includes linux/acpi.h the build > > breaks with: > >=20 > > In file included from ../include/acpi/platform/acenv.h:150:0, > > from ../include/acpi/acpi.h:56, > > from ../include/linux/match.h:2, > > from ../drivers/i2c/i2c-core.c:43: > > ../include/acpi/platform/aclinux.h:73:23: > > fatal error: asm/acenv.h: No such file or directory > > #include > > ^ >=20 > Which kernel does this happen with? a0a962d (tag: refs/tags/next-20140602, refs/remotes/next/master) Add linux-next specific files for 20140602 > > Cc: Lv Zheng > > Cc: Rafael J. Wysocki > > Cc: linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Cc: devel-E0kO6a4B6psdnm+yROfE0A@public.gmane.org > > Signed-off-by: Lee Jones > > --- > > include/acpi/platform/aclinux.h | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > >=20 > > diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platfor= m/aclinux.h > > index cd1f052..fdf7663 100644 > > --- a/include/acpi/platform/aclinux.h > > +++ b/include/acpi/platform/aclinux.h > > @@ -70,9 +70,10 @@ > > #ifdef EXPORT_ACPI_INTERFACES > > #include > > #endif > > -#include > > =20 > > -#ifndef CONFIG_ACPI > > +#ifdef CONFIG_ACPI > > +#include > > +#else > > =20 > > /* External globals for __KERNEL__, stubs is needed */ > > =20 > >=20 >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 4 Jun 2014 13:51:37 +0100 Subject: [PATCH 1/7] ACPICA: Only include ACPI asm files if ACPI is enabled In-Reply-To: <3061297.feg5DGUjIt@vostro.rjw.lan> References: <1401883796-17841-1-git-send-email-lee.jones@linaro.org> <1401883796-17841-2-git-send-email-lee.jones@linaro.org> <3061297.feg5DGUjIt@vostro.rjw.lan> Message-ID: <20140604125137.GA18171@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 04 Jun 2014, Rafael J. Wysocki wrote: > On Wednesday, June 04, 2014 01:09:50 PM Lee Jones wrote: > > Any drivers which support ACPI and Device Tree probing need to include > > both respective header files. Without this patch, if a driver is being > > used on a platform which does not support ACPI and subsequently does not > > have the config option enabled, but includes linux/acpi.h the build > > breaks with: > > > > In file included from ../include/acpi/platform/acenv.h:150:0, > > from ../include/acpi/acpi.h:56, > > from ../include/linux/match.h:2, > > from ../drivers/i2c/i2c-core.c:43: > > ../include/acpi/platform/aclinux.h:73:23: > > fatal error: asm/acenv.h: No such file or directory > > #include > > ^ > > Which kernel does this happen with? a0a962d (tag: refs/tags/next-20140602, refs/remotes/next/master) Add linux-next specific files for 20140602 > > Cc: Lv Zheng > > Cc: Rafael J. Wysocki > > Cc: linux-acpi at vger.kernel.org > > Cc: devel at acpica.org > > Signed-off-by: Lee Jones > > --- > > include/acpi/platform/aclinux.h | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h > > index cd1f052..fdf7663 100644 > > --- a/include/acpi/platform/aclinux.h > > +++ b/include/acpi/platform/aclinux.h > > @@ -70,9 +70,10 @@ > > #ifdef EXPORT_ACPI_INTERFACES > > #include > > #endif > > -#include > > > > -#ifndef CONFIG_ACPI > > +#ifdef CONFIG_ACPI > > +#include > > +#else > > > > /* External globals for __KERNEL__, stubs is needed */ > > > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752870AbaFDMvt (ORCPT ); Wed, 4 Jun 2014 08:51:49 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:61263 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752401AbaFDMvr (ORCPT ); Wed, 4 Jun 2014 08:51:47 -0400 Date: Wed, 4 Jun 2014 13:51:37 +0100 From: Lee Jones To: "Rafael J. Wysocki" Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, wsa@the-dreams.de, grant.likely@linaro.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, Lv Zheng , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, devel@acpica.org Subject: Re: [PATCH 1/7] ACPICA: Only include ACPI asm files if ACPI is enabled Message-ID: <20140604125137.GA18171@lee--X1> References: <1401883796-17841-1-git-send-email-lee.jones@linaro.org> <1401883796-17841-2-git-send-email-lee.jones@linaro.org> <3061297.feg5DGUjIt@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3061297.feg5DGUjIt@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Jun 2014, Rafael J. Wysocki wrote: > On Wednesday, June 04, 2014 01:09:50 PM Lee Jones wrote: > > Any drivers which support ACPI and Device Tree probing need to include > > both respective header files. Without this patch, if a driver is being > > used on a platform which does not support ACPI and subsequently does not > > have the config option enabled, but includes linux/acpi.h the build > > breaks with: > > > > In file included from ../include/acpi/platform/acenv.h:150:0, > > from ../include/acpi/acpi.h:56, > > from ../include/linux/match.h:2, > > from ../drivers/i2c/i2c-core.c:43: > > ../include/acpi/platform/aclinux.h:73:23: > > fatal error: asm/acenv.h: No such file or directory > > #include > > ^ > > Which kernel does this happen with? a0a962d (tag: refs/tags/next-20140602, refs/remotes/next/master) Add linux-next specific files for 20140602 > > Cc: Lv Zheng > > Cc: Rafael J. Wysocki > > Cc: linux-acpi@vger.kernel.org > > Cc: devel@acpica.org > > Signed-off-by: Lee Jones > > --- > > include/acpi/platform/aclinux.h | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h > > index cd1f052..fdf7663 100644 > > --- a/include/acpi/platform/aclinux.h > > +++ b/include/acpi/platform/aclinux.h > > @@ -70,9 +70,10 @@ > > #ifdef EXPORT_ACPI_INTERFACES > > #include > > #endif > > -#include > > > > -#ifndef CONFIG_ACPI > > +#ifdef CONFIG_ACPI > > +#include > > +#else > > > > /* External globals for __KERNEL__, stubs is needed */ > > > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog