Re: [PATCH] Xen: Spread boot time page scrubbing across all available CPU's (v5)

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Jun 04, 2014 at 02:35:49PM +0100, Andrew Cooper wrote:
> On 04/06/14 14:29, Konrad Rzeszutek Wilk wrote:
> > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
> > index 514c7b2..39a67be 100644
> > --- a/docs/misc/xen-command-line.markdown
> > +++ b/docs/misc/xen-command-line.markdown
> > @@ -198,6 +198,16 @@ Scrub free RAM during boot.  This is a safety feature to prevent
> >  accidentally leaking sensitive VM data into other VMs if Xen crashes
> >  and reboots.
> >  
> > +### bootscrub_chunk_
> > +> `= <size>`
> > +
> > +> Default: `128MB`
> 
> The 'B' here is still erroneous.
> 
> >      printk("done.\n");
> > diff --git a/xen/include/asm-arm/numa.h b/xen/include/asm-arm/numa.h
> > index cb8f2ba..2c019d7 100644
> > --- a/xen/include/asm-arm/numa.h
> > +++ b/xen/include/asm-arm/numa.h
> > @@ -12,6 +12,7 @@ static inline __attribute__((pure)) int phys_to_nid(paddr_t addr)
> >  
> >  /* XXX: implement NUMA support */
> >  #define node_spanned_pages(nid) (total_pages)
> > +#define node_start_pfn(nid) (frametable_base_mfn)
> 
> What is this supposed to achieve?

Make it scrub memory on ARM (which define a flat 1 NODE NUMA topology).
Perhaps I am not understanding your question?

> 
> ~Andrew
> 
> >  #define __node_distance(a, b) (20)
> >  
> >  #endif /* __ARCH_ARM_NUMA_H */
>