From: Frederic Weisbecker <fweisbec@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Kevin Hilman <khilman@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linaro Networking <linaro-networking@linaro.org>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [Query] Can we use normal timers (kernel/timer.c) while in NO_HZ_FULL mode?
Date: Wed, 4 Jun 2014 16:05:14 +0200 [thread overview]
Message-ID: <20140604140512.GD13827@localhost.localdomain> (raw)
In-Reply-To: <CAKohpo=JRKO7x3izE7jG-MAUdXexNzxpG0FT5adNQmKi0+Bauw@mail.gmail.com>
On Wed, Jun 04, 2014 at 07:14:43PM +0530, Viresh Kumar wrote:
> On 4 June 2014 18:53, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > Right, if we enqueue a timer when the tick is stopped, we call wake_up_nohz_cpu().
>
> Ahh, I looked at __mod_timer() :)
>
> BTW, shouldn't we do something similar for mod_timer_pinned()
> as well ?
Ah that looks right. In fact we should probably move the wake_up_nohz_cpu()
to internal_add_timer().
And that concerns nohz idle as well. If mod_timer() selects a CPU that doesn't
appear to be idle in get_nohz_timer_target() but then becomes idle afterward
before we lock its timer base, the CPU may well miss the timer.
prev parent reply other threads:[~2014-06-04 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:41 [Query] Can we use normal timers (kernel/timer.c) while in NO_HZ_FULL mode? Viresh Kumar
2014-06-04 13:23 ` Frederic Weisbecker
2014-06-04 13:44 ` Viresh Kumar
2014-06-04 13:53 ` Viresh Kumar
2014-06-04 14:06 ` Frederic Weisbecker
2014-06-04 14:05 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604140512.GD13827@localhost.localdomain \
--to=fweisbec@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=khilman@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linaro-networking@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.