From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsFQF-0002Z4-Jt for qemu-devel@nongnu.org; Wed, 04 Jun 2014 13:56:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsFQ8-0001Im-JG for qemu-devel@nongnu.org; Wed, 04 Jun 2014 13:56:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsFQ8-0001IK-Ai for qemu-devel@nongnu.org; Wed, 04 Jun 2014 13:56:16 -0400 Message-Id: <20140604175446.569449721@amt.cnet> Date: Wed, 04 Jun 2014 14:52:03 -0300 From: mtosatti@redhat.com References: <20140604175200.667995104@amt.cnet> Content-Disposition: inline; filename=rtc-add-link Subject: [Qemu-devel] [patch 3/3] mc146818rtc: add "rtc" link to "/machine" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: gleb@kernel.org, mprivozn@redhat.com, Marcelo Tosatti , armbru@redhat.com, pbonzini@redhat.com Add a link to rtc under /machine providing a stable location for management apps to query "date" field. {"execute":"qom-get","arguments":{"path":"/machine/rtc","property":"date"} } Suggested by Paolo Bonzini. Signed-off-by: Marcelo Tosatti --- hw/timer/mc146818rtc.c | 9 +++++++++ 1 file changed, 9 insertions(+) Index: qemu/hw/timer/mc146818rtc.c =================================================================== --- qemu.orig/hw/timer/mc146818rtc.c 2014-06-02 23:14:11.707436729 -0300 +++ qemu/hw/timer/mc146818rtc.c 2014-06-02 23:14:15.453424684 -0300 @@ -911,6 +911,9 @@ object_property_add(OBJECT(s), "date", "struct tm", rtc_get_date, NULL, NULL, s, NULL); + + object_property_add_alias(qdev_get_machine(), "rtc", OBJECT(s), + &error_abort); } ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) @@ -954,11 +957,17 @@ dc->cannot_instantiate_with_device_add_yet = true; } +static void rtc_finalize(Object *obj) +{ + object_property_del(qdev_get_machine(), "rtc", NULL); +} + static const TypeInfo mc146818rtc_info = { .name = TYPE_MC146818_RTC, .parent = TYPE_ISA_DEVICE, .instance_size = sizeof(RTCState), .class_init = rtc_class_initfn, + .instance_finalize = rtc_finalize, }; static void mc146818rtc_register_types(void)