From: Jesse Barnes <jesse.barnes@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Update bits to check in device class from VBT to detect eDP
Date: Thu, 5 Jun 2014 09:04:17 -0700 [thread overview]
Message-ID: <20140605090417.75cd648b@jbarnes-desktop> (raw)
In-Reply-To: <20140605130929.GB27580@intel.com>
On Thu, 5 Jun 2014 16:09:29 +0300
Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Jun 05, 2014 at 06:25:13PM +0530, Shobhit Kumar wrote:
> > The DEVICE_TYPE_eDP has been changed to 0x1806 in case of BYT which
> > can causes wrong detection failures for eDP. Reduce the number of bits
> > of interest in DEVICE_TYPE_eDP_BITS to just check most relevant and
> > conclusive ones and ensure they are set in device_class from VBT. This
> > will ensure that eDP detection works across platforms
>
> The current bits will match correctly for 0x1806. I don't have a problem
> with the patch per-say but would be nice to know what the troublesome
> device type really was, if indeed there was one. I'm just slightly
> worried that we might start to get false positives on some platforms if
> we make it too relaxed.
Still waiting for results, but
https://bugs.freedesktop.org/show_bug.cgi?id=78795 was what motivated this.
Jesse
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-06-05 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 12:55 [PATCH] drm/i915: Update bits to check in device class from VBT to detect eDP Shobhit Kumar
2014-06-05 13:09 ` Ville Syrjälä
2014-06-05 16:04 ` Jesse Barnes [this message]
2014-06-06 4:03 ` Kumar, Shobhit
2014-06-06 5:36 ` Kumar, Shobhit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605090417.75cd648b@jbarnes-desktop \
--to=jesse.barnes@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.