From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 3/3] drm/tegra: Fix sequencing Date: Thu, 5 Jun 2014 11:20:52 +0200 Message-ID: <20140605092049.GC22966@ulmo> References: <1400815968-1084-1-git-send-email-marcheu@chromium.org> <1400815968-1084-3-git-send-email-marcheu@chromium.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1967953493==" Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BF326E92A for ; Thu, 5 Jun 2014 02:23:38 -0700 (PDT) Received: by mail-wi0-f179.google.com with SMTP id bs8so3050012wib.0 for ; Thu, 05 Jun 2014 02:23:38 -0700 (PDT) In-Reply-To: <1400815968-1084-3-git-send-email-marcheu@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?utf-8?B?U3TDqXBoYW5l?= Marchesin Cc: treding@nvidia.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1967953493== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5G06lTa6Jq83wMTw" Content-Disposition: inline --5G06lTa6Jq83wMTw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 22, 2014 at 08:32:48PM -0700, St=C3=A9phane Marchesin wrote: > I suspect this is a copy/paste error. >=20 > Signed-off-by: St=C3=A9phane Marchesin > --- > drivers/gpu/drm/tegra/sor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Would you mind if I extend the commit message with something like the following: Lanes are powered up in decreasing order, so they should be powered down in increasing order. Also does this fix any issues in particular that you were seeing or is it just an "oddity" that you noticed during review? At least on Venice2 it doesn't seem to matter in what order the lanes are powered up or down. Thierry --5G06lTa6Jq83wMTw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTkDZxAAoJEN0jrNd/PrOhbcgP/1Z7zjaLkVqFLe5+s9777eN5 PGwOYmGTiPSa6aVAgpaBMTGb8DyUlpbi5lVQSNoETby+0Us/LqUEgJxfuk6qb9LJ BseZFDT9iaLeaZXv/YtnyqRAzE8BJKJ3Q5G3djW6ZkDLam+uNvy970LdzqjCtEkP z/vTnb9Tpui7Wy8sWen/MLIKcinv2utHycvPpBesjAt5Hfg8U44Fc9WOfP09tOnJ KfGClcgUJgRpiTGjdt8XVp6rfba6009SkRQeaBTvinebeCkiJCNf8x+iIIElKaEM GezR1AoKhFn0weXns5fyPsZ6VelUiLgXP5GX+EaIUdUXOX7l8tywXEoDNk3LtvNX giHQUfu2Clf/G818RmqERZzxKZZf/QnLfp7xLZI4x8QSvWtlQ+YgrJDC8DQ6JloR 4b/6ihsaZJPFGDxFHmuNpZMs3AJ+nhdky6NrNYmcLA5BkJCwPEiBS8PhqbV7Dq5w Y+dn4yKUYN6dnlm6HNT9Z7Zv9CXoNuH1Z04F4PD7P/LQLH3sRyk15ibP0en4HCYo K6pobLQZEBl3W9nG4/6msHTdCfyQ+21qMB89kcQZSBBwAupoPWcv3ZPrloNEHvxF TMX23CN4ka1t2oA5b8b+ql5rWy4Mx6mDaDlExrUuzVgr8wx5t5WQTXnXEMLm4dxm gj1VoLz6u2SuiAaWQ8qZ =UQ6D -----END PGP SIGNATURE----- --5G06lTa6Jq83wMTw-- --===============1967953493== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1967953493==--