From: Christoph Hellwig <hch@infradead.org>
To: Douglas Gilbert <dgilbert@interlog.com>
Cc: SCSI development list <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
James Bottomley <JBottomley@parallels.com>,
openosd@gmail.com
Subject: Re: [PATCH v2] sg: add SG_FLAG_Q_AT_TAIL flag
Date: Thu, 5 Jun 2014 02:24:10 -0700 [thread overview]
Message-ID: <20140605092410.GA727@infradead.org> (raw)
In-Reply-To: <538F3416.5090306@interlog.com>
On Wed, Jun 04, 2014 at 10:58:30AM -0400, Douglas Gilbert wrote:
> When the SG_IO ioctl was copied into the block layer and
> later into the bsg driver, subtle differences emerged.
>
> One difference is the way injected commands are queued through
> the block layer (i.e. this is not SCSI device queueing nor SATA
> NCQ). Summarizing:
> - SG_IO in the block layer: blk_exec*(at_head=false)
> - sg SG_IO: at_head=true
> - bsg SG_IO: at_head=true
>
> Some time ago Boaz Harrosh introduced a sg v4 flag called
> BSG_FLAG_Q_AT_TAIL to override the bsg driver default.
> This patch does the equivalent for the sg driver.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Any chance to get a patch for the block-layer SG_IO code, too?
next prev parent reply other threads:[~2014-06-05 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 14:58 [PATCH v2] sg: add SG_FLAG_Q_AT_TAIL flag Douglas Gilbert
2014-06-05 9:24 ` Christoph Hellwig [this message]
2014-06-05 15:27 ` Boaz Harrosh
2014-06-05 17:16 ` Jeremy Linton
2014-06-05 22:09 ` Douglas Gilbert
2014-06-11 14:54 ` Ewan Milne
2014-06-11 21:14 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605092410.GA727@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
--cc=openosd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.