All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Ingo Molnar <mingo@elte.hu>, Denys Vlasenko <dvlasenk@redhat.com>,
	Jim Keniston <jkenisto@us.ibm.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] uprobes/x86: Rename arch_uprobe->def into ->dflt, minor comment updates
Date: Thu, 5 Jun 2014 11:28:50 +0200	[thread overview]
Message-ID: <20140605092850.GA4632@gmail.com> (raw)
In-Reply-To: <20140604163945.GA26429@redhat.com>


* Oleg Nesterov <oleg@redhat.com> wrote:

> On 06/04, Masami Hiramatsu wrote:
> >
> > (2014/06/04 4:13), Oleg Nesterov wrote:
> > > On 06/03, Ingo Molnar wrote:
> > >>
> > >> So exactly what do those fields do? If it's scratch register handling,
> > >> would it be logical to name it arch_uprobe->scratch, or so?
> > >
> > > Not only, ->fixups encodes other flags. and ->ilen is used by UPROBE_FIX_CALL.
> > >
> > > arch_uprobe->def contains the arguments for default_xol_ops methods, currently
> > > this handles everything except relative jmp/call insns.
> > >
> > > So perhaps ->dflt is not that ugly in this case? I simply do not see anything
> > > better. But again, I agree with any name in advance.
> >
> > Hmm, how about ->defparam ? :)
> 
> Fine with me ;)
> 
> Ingo, will you agree with s/def/defparam/ ?

Certainly! :)

Thanks,

	Ingo

  reply	other threads:[~2014-06-05  9:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-01 19:25 [PATCH] uprobes/x86: Rename arch_uprobe->def into ->dflt, minor comment updates Oleg Nesterov
2014-06-02  1:29 ` Masami Hiramatsu
2014-06-02  6:04 ` Srikar Dronamraju
2014-06-02 15:27 ` Jim Keniston
2014-06-03 18:21 ` Ingo Molnar
2014-06-03 18:30   ` Oleg Nesterov
2014-06-03 18:39     ` Ingo Molnar
2014-06-03 19:13       ` Oleg Nesterov
2014-06-04  3:16         ` Masami Hiramatsu
2014-06-04 16:39           ` Oleg Nesterov
2014-06-05  9:28             ` Ingo Molnar [this message]
2014-06-05 14:33               ` [GIT PULL] uprobes: tmpfs support (Was: uprobes/x86: Rename arch_uprobe->def into ->dflt, minor comment updates) Oleg Nesterov
2014-06-05 14:54                 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140605092850.GA4632@gmail.com \
    --to=mingo@kernel.org \
    --cc=dvlasenk@redhat.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.