Re: [libnftnl PATCH 1/5] expr: reject: Add nft_rule_expr_reject_snprinf_* functions

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Jun 04, 2014 at 01:38:07PM +0200, Ana Rey wrote:
> Code refactoring in nft_rule_expr_reject_snprinf functions. This process
> adds three new functions:
> 
> * nft_rule_expr_reject_snprinf_default
> * nft_rule_expr_reject_snprinf_xml
> * nft_rule_expr_reject_snprinf_json

Applied with minor changes.

> Signed-off-by: Ana Rey <anarey@gmail.com>
> ---
>  src/expr/reject.c | 42 ++++++++++++++++++++++++++++++++----------
>  1 file changed, 32 insertions(+), 10 deletions(-)
> 
> diff --git a/src/expr/reject.c b/src/expr/reject.c
> index 62346e9..cefaf98 100644
> --- a/src/expr/reject.c
> +++ b/src/expr/reject.c
> @@ -174,24 +174,46 @@ nft_rule_expr_reject_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
>  #endif
>  }
>  
> +static int nft_rule_expr_reject_snprintf_default(char *buf, size_t len,
> +						 struct nft_rule_expr *e)
> +{
> +	struct nft_expr_reject *reject = nft_expr_data(e);
> +
> +	return snprintf(buf, len, "type %u code %u  ",
                                                   ^
removed extra whitespace. Not your fault, but good to fix it now that
we're just passing by this code.