From: Florian Westphal <fw@strlen.de>
To: Yuxuan Shui <yshuiv7@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] netfilter: Add SKPID and SKSID meta keys
Date: Thu, 5 Jun 2014 16:25:25 +0200 [thread overview]
Message-ID: <20140605142525.GB23367@breakpoint.cc> (raw)
In-Reply-To: <1401977956-15500-3-git-send-email-yshuiv7@gmail.com>
Yuxuan Shui <yshuiv7@gmail.com> wrote:
+ case NFT_META_SKPID:
> + if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
> + goto err;
> +
> + read_lock_bh(&skb->sk->sk_callback_lock);
> + dest->data[0] = pid_nr(skb->sk->sk_peer_pid);
> + read_unlock_bh(&skb->sk->sk_callback_lock);
> + break;
> + case NFT_META_SKSID:
> + if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
> + goto err;
> +
> + read_lock_bh(&skb->sk->sk_callback_lock);
> + task = get_pid_task(skb->sk->sk_peer_pid, PIDTYPE_PID);
> + sid = task_session(task);
> + if (!sid)
looks like you need to unlock here.
> + goto err;
next prev parent reply other threads:[~2014-06-05 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 14:19 [PATCH nftables 1/3] meta: Add support for SKPID and SKSID meta keys Yuxuan Shui
2014-06-05 14:19 ` [PATCH libnftnl 2/3] " Yuxuan Shui
2014-06-05 14:19 ` [PATCH 3/3] netfilter: Add " Yuxuan Shui
2014-06-05 14:25 ` Florian Westphal [this message]
2014-06-10 11:01 ` Pablo Neira Ayuso
2014-06-19 10:16 ` Tomasz Bursztyka
2014-06-19 10:19 ` Pablo Neira Ayuso
2014-06-19 10:25 ` Tomasz Bursztyka
2014-06-21 14:40 ` [PATCH v2] " Yuxuan Shui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605142525.GB23367@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=yshuiv7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.