From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752412AbaFEP4a (ORCPT ); Thu, 5 Jun 2014 11:56:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52990 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbaFEP42 (ORCPT ); Thu, 5 Jun 2014 11:56:28 -0400 Date: Thu, 5 Jun 2014 09:00:10 -0700 From: Greg KH To: Frank Haverkamp Cc: Kleber Sacilotto de Souza , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] GenWQE: Increase driver version number Message-ID: <20140605160010.GF23993@kroah.com> References: <1401890273-13067-1-git-send-email-klebers@linux.vnet.ibm.com> <1401890273-13067-5-git-send-email-klebers@linux.vnet.ibm.com> <20140604155454.GA2866@kroah.com> <1401960184.11932.10.camel@oc7383187364.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401960184.11932.10.camel@oc7383187364.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 05, 2014 at 11:23:04AM +0200, Frank Haverkamp wrote: > Hi Greg, > > Am Mittwoch, den 04.06.2014, 08:54 -0700 schrieb Greg KH: > > On Wed, Jun 04, 2014 at 10:57:53AM -0300, Kleber Sacilotto de Souza wrote: > > > Increase genwqe driver version number. > > > > > > Signed-off-by: Kleber Sacilotto de Souza > > > --- > > > drivers/misc/genwqe/genwqe_driver.h | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/misc/genwqe/genwqe_driver.h b/drivers/misc/genwqe/genwqe_driver.h > > > index cd52631..a506e9a 100644 > > > --- a/drivers/misc/genwqe/genwqe_driver.h > > > +++ b/drivers/misc/genwqe/genwqe_driver.h > > > @@ -36,7 +36,7 @@ > > > #include > > > #include > > > > > > -#define DRV_VERS_STRING "2.0.15" > > > +#define DRV_VERS_STRING "2.0.21" > > > > Why is this even needed? Can't you go off of the kernel version number > > now? Who needs / wants this number? > > I am aware that if just considering the mainline kernels, we could use > the kernel version itself for the purpose of identifying which code we > are running. Which is what you are patching here :) > But in our lab we are running multiple back-ported versions of this > driver on different Linux distributions using different kernel versions. Then deal with that in the backported code, the upstream kernel doesn't care about this. > Our user-space software needs to know if the driver has or has not > bug-fixes or features. For this purpose, we are using this extra number. Why would you rely on a version number for this, shouldn't you be able to tell with your api what features are present? thanks, greg k-h