From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51053)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WsaPi-0006VQ-Cz
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:21:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WsaPc-0008Pk-59
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:21:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8027)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WsaPb-0008PE-So
	for qemu-devel@nongnu.org; Thu, 05 Jun 2014 12:21:08 -0400
Date: Thu, 5 Jun 2014 19:21:34 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140605162134.GA11408@redhat.com>
References: <1399312987-29499-1-git-send-email-dslutz@verizon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1399312987-29499-1-git-send-email-dslutz@verizon.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 0/2] qdev: Display warning about unused
	-global
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <dslutz@verizon.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Mon, May 05, 2014 at 02:03:05PM -0400, Don Slutz wrote:
> I might have named this v2, but since this is a split out of:
>=20
> [PATCH v3 2/4] GlobalProperty: Display warning about unused -global
>=20
> From:
>=20
> [PATCH v3 0/4] Add max-ram-below-4g (was Add pci_hole_min_size machine =
option)
>=20
> I feel v4 is better.

Applied, thanks!

> Changes v3 to v4:
>   Add a new patch to add a check in test-qdev-global-props.c
>   Changed qdev_prop_check_global() to return state.  Only used
>   by unit test.
>   Change to use error_report().
>=20
>   Andreas F=E4rber:
>     Added hotpluggable checking.
>     Renamed to qdev:
>=20
>   Did not do:
>     Add a separate linked list:
>       This looked to me to increase the complexity without any benefit.
>     Adjust where vl.c calls qdev_prop_check_global().
>       Since this is just before migration starts, I still think this
>       is the best place.  I did a quick look into adding some test
>       that checks that this is still working, but only found qemu-iotes=
t
>       doing the QEMU output check for expected output.  It did not
>       make sense to me to add a global property check there.
>=20
>   Paolo Bonzini:
>     Added a comment before definition of the not_used field.
>=20
>=20
>=20
> Don Slutz (2):
>   qdev: Display warning about unused -global
>   qdev: Add test of qdev_prop_check_global
>=20
>  hw/core/qdev-properties-system.c | 16 ++++++++++++++++
>  hw/core/qdev-properties.c        | 18 ++++++++++++++++++
>  include/hw/qdev-core.h           |  8 ++++++++
>  include/hw/qdev-properties.h     |  1 +
>  tests/test-qdev-global-props.c   |  4 ++++
>  vl.c                             |  2 ++
>  6 files changed, 49 insertions(+)
>=20
> --=20
> 1.8.4